Skip to content

Conversation

@JiabinYang
Copy link
Contributor

PR types

Function optimization

PR changes

APIs

Describe

This PR remove bfloat16/float16/complex64/complex128 types to make CustomOp support prediction C++ api

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Shixiaowei02
Shixiaowei02 previously approved these changes Feb 26, 2021
@JiabinYang JiabinYang changed the title Remove unsupport dtypes [Custom Op] Remove unsupport dtypes Feb 26, 2021
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

#include <stdexcept>
#include <string>

#pragma once
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

放到最上面?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@JiabinYang JiabinYang merged commit 0c38708 into PaddlePaddle:develop Feb 26, 2021
chenwhql pushed a commit to chenwhql/Paddle that referenced this pull request Feb 27, 2021
* remove remove_unsupport_dtype

* remove remove_unsupport_dtype

* remove test dtype

* add more include

* change dtype.h's enum as enum class to avoid conflict with inference lib

* make enum as enum class

* remove additional test

* merge develop

* polish code
chenwhql pushed a commit to chenwhql/Paddle that referenced this pull request Feb 27, 2021
* remove remove_unsupport_dtype

* remove remove_unsupport_dtype

* remove test dtype

* add more include

* change dtype.h's enum as enum class to avoid conflict with inference lib

* make enum as enum class

* remove additional test

* merge develop

* polish code
lanxianghit pushed a commit that referenced this pull request Feb 28, 2021
* modify custom op dependent from paddle_framework to paddle_custom_op (#31195)

* [Custom Op] Remove unsupport dtypes (#31232)

* remove remove_unsupport_dtype

* remove remove_unsupport_dtype

* remove test dtype

* add more include

* change dtype.h's enum as enum class to avoid conflict with inference lib

* make enum as enum class

* remove additional test

* merge develop

* polish code

* [Custom OP] Support stream set on Custom Op (#31257)

* [Custom OP] change the user header file format, test=develop (#31274)

* [Custom OP]add PD_THROW and PD_CHECK for User Error message (#31253)

* [Custom OP]add PD_THROW and PD_CHECK for User error message

* PD_THROW and PD_CHECK, fix comment

* fix Windows error message

* fix Windows error message

* fix CI

* [Custom OP]add MSVC compile check on Windows (#31265)

* fix test_check_abi

Co-authored-by: Zhou Wei <52485244+zhouwei25@users.noreply.github.com>
Co-authored-by: Jiabin Yang <marsyang199376@gmail.com>
Co-authored-by: 石晓伟 <39303645+Shixiaowei02@users.noreply.github.com>
Co-authored-by: zhouwei25 <zhouwei25@baidu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants