-
Couldn't load subscription status.
- Fork 5.9k
[Custom OP] Support stream set on Custom Op #31257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JiabinYang
merged 8 commits into
PaddlePaddle:develop
from
JiabinYang:support_stream_set
Feb 26, 2021
Merged
[Custom OP] Support stream set on Custom Op #31257
JiabinYang
merged 8 commits into
PaddlePaddle:develop
from
JiabinYang:support_stream_set
Feb 26, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add more include make StreamWrapper into tensor.h remove additional dtype make enum as enum class debug debug debug debug debug debug debug debug debug debug debug debug debug debug debug debug debug debug debug debug debug debug debug debug debug debug debug debug debug debug debug debug remove additional tests
… support_stream_set
chenwhql
approved these changes
Feb 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Aurelius84
approved these changes
Feb 26, 2021
chenwhql
pushed a commit
to chenwhql/Paddle
that referenced
this pull request
Feb 27, 2021
chenwhql
pushed a commit
to chenwhql/Paddle
that referenced
this pull request
Feb 27, 2021
lanxianghit
pushed a commit
that referenced
this pull request
Feb 28, 2021
* modify custom op dependent from paddle_framework to paddle_custom_op (#31195) * [Custom Op] Remove unsupport dtypes (#31232) * remove remove_unsupport_dtype * remove remove_unsupport_dtype * remove test dtype * add more include * change dtype.h's enum as enum class to avoid conflict with inference lib * make enum as enum class * remove additional test * merge develop * polish code * [Custom OP] Support stream set on Custom Op (#31257) * [Custom OP] change the user header file format, test=develop (#31274) * [Custom OP]add PD_THROW and PD_CHECK for User Error message (#31253) * [Custom OP]add PD_THROW and PD_CHECK for User error message * PD_THROW and PD_CHECK, fix comment * fix Windows error message * fix Windows error message * fix CI * [Custom OP]add MSVC compile check on Windows (#31265) * fix test_check_abi Co-authored-by: Zhou Wei <52485244+zhouwei25@users.noreply.github.com> Co-authored-by: Jiabin Yang <marsyang199376@gmail.com> Co-authored-by: 石晓伟 <39303645+Shixiaowei02@users.noreply.github.com> Co-authored-by: zhouwei25 <zhouwei25@baidu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
APIs
Describe
This PR support stream get from Tensor which has been set stream during RunKernelFunc. This may solve performance issue caused by stream sync in GPU mode