Fixing pseudo packing functions #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clearance and edges args now work fine.
|
Got pseudo_gravity_packing working well, the clearance and mode args now work. And adding new spheres to existing structures works...
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #922 +/- ##
=======================================
- Coverage 83.1% 83.0% -0.2%
=======================================
Files 36 36
Lines 4577 4662 +85
=======================================
+ Hits 3807 3872 +65
- Misses 770 790 +20 |
…lways returning only spheres
|
Now that we have declared the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #916
Fixes #757
Fixes #649
Fixes #647
Fixes #575
Fixes #805
Dont' Merge This PR Yet, Wait for V3
This PR contains reimplementations of the pseudo-packing functions. I rewrote them using a totally different logic so they don't output the same results as the previous ones (quantitatively different, qualitatively the same). The new algorithms both use a queue based method and share a good chunk of code. They seem to be about the same speed, but are much easier to understand now. They also work a lot better. Not only do the original features all work now, but I have added several new args such as
phi(solid volume fraction).Anyway, because these functions return different results, it is technically mandatory to wait until releasing version 3 to merge this PR.