Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant edges argument in pseudo_gravity_packing #916

Closed
heinsimon opened this issue Mar 6, 2024 · 1 comment · Fixed by #922
Closed

Redundant edges argument in pseudo_gravity_packing #916

heinsimon opened this issue Mar 6, 2024 · 1 comment · Fixed by #922
Labels
bug PR tag for bug fixes

Comments

@heinsimon
Copy link
Contributor

The documentation and the function header include the argument 'edges'. Changing this argument from default value does not change anything in the output.

Checking the source code revealed: it is not used within the function itself.

I would expect either an error/warning when changing the argument from default value or not having this argument at all.

@jgostick
Copy link
Member

jgostick commented Mar 6, 2024

That function is in need of some fixes. I think there are already some bug reports on the issue tracker so I'll affect this to the list.

@jgostick jgostick added the bug PR tag for bug fixes label Mar 8, 2024
@ma-sadeghi ma-sadeghi changed the title pseudo_gravity_packing: Argument 'edges' not used but accepted pseudo_gravity_packing: Argument 'edges' not used but accepted Mar 8, 2024
@ma-sadeghi ma-sadeghi changed the title pseudo_gravity_packing: Argument 'edges' not used but accepted Redundant edges argument in pseudo_gravity_packing Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug PR tag for bug fixes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants