Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add volume_fraction as an optional argument to packing generators #575

Closed
ma-sadeghi opened this issue Aug 13, 2021 · 2 comments · Fixed by #922
Closed

Add volume_fraction as an optional argument to packing generators #575

ma-sadeghi opened this issue Aug 13, 2021 · 2 comments · Fixed by #922
Labels
discussion Requires some thought and input from developers

Comments

@ma-sadeghi
Copy link
Member

No description provided.

@jgostick
Copy link
Member

I'm not sure that would work since packing generators usually pack tightly, except for RSA with has a volume_fraction argument

@jgostick jgostick reopened this Mar 18, 2022
@jgostick
Copy link
Member

I suppose they could have a volume_fraction argument, like RSA, and that stops the process before maxiter is reached, where volume fraction if a global fraction

@jgostick jgostick changed the title Add porosity as an optional argument to packing generators Add volume_fraction as an optional argument to packing generators Mar 19, 2022
@ma-sadeghi ma-sadeghi added discussion Requires some thought and input from developers proposal and removed proposal labels Jul 29, 2023
@ma-sadeghi ma-sadeghi changed the title Add volume_fraction as an optional argument to packing generators Add volume_fraction as an optional argument to packing generators Jul 29, 2023
@jgostick jgostick mentioned this issue Mar 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion Requires some thought and input from developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing pseudo packing functions PMEAL/porespy
2 participants
@jgostick @ma-sadeghi