Generic/LowerCaseKeyword: remove some redundant code #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Tokens::$contextSensitiveKeywords` token array was introduced in PHPCS 3.7.0 via PR squizlabs/PHP_CodeSniffer 3484. PR squizlabs/PHP_CodeSniffer 3574 build onto that by removing the bulk of the target tokens from the `register()` method for the Generic/LowerCaseKeyword sniff in favour of using the predefined `Tokens::$contextSensitiveKeywords` token array. The `T_EMPTY`, `T_EVAL`, `T_ISSET` and `T_UNSET` tokens were initially missing from the `Tokens::$contextSensitiveKeywords` array. This was fixed in PHPCS 3.7.1 via PRs squizlabs/PHP_CodeSniffer 3608 and squizlabs/PHP_CodeSniffer 3610. This means those tokens no longer need to be explicitly added as targets for the Generic/LowerCaseKeyword sniff as they are now (and have been since PHPCS 3.7.1) inherited via the `Tokens::$contextSensitiveKeywords` token array. This commit removes the redundancy, but also adds tests to safeguard that those keywords will still be checked by the sniff.
jrfnl
deleted the
feature/generic-lowercasekeyword-remove-redundant-targets
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
Tokens::$contextSensitiveKeywordstoken array was introduced in PHPCS 3.7.0 via PR squizlabs/PHP_CodeSniffer#3484.PR squizlabs/PHP_CodeSniffer#3574 build onto that by removing the bulk of the target tokens from the
register()method for the Generic/LowerCaseKeyword sniff in favour of using the predefinedTokens::$contextSensitiveKeywordstoken array.The
T_EMPTY,T_EVAL,T_ISSETandT_UNSETtokens were initially missing from theTokens::$contextSensitiveKeywordsarray. This was fixed in PHPCS 3.7.1 via PRs squizlabs/PHP_CodeSniffer#3608 and squizlabs/PHP_CodeSniffer#3610.This means those tokens no longer need to be explicitly added as targets for the Generic/LowerCaseKeyword sniff as they are now (and have been since PHPCS 3.7.1) inherited via the
Tokens::$contextSensitiveKeywordstoken array.This commit removes the redundancy, but also adds tests to safeguard that those keywords will still be checked by the sniff.
Suggested changelog entry
N/A
Related issues/external references
Noticed the redundancy while reviewing #597.