PHP 8.1 | Generic/LowerCaseKeyword: simplify registered tokens + add enum support
#3574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enum support This is a PR to simplify maintenance of this sniff. Since PR 3484, the `Tokens` class contains a `$contextSensitiveKeywords` property which largely overlaps with the list of tokens registered for this sniff. All tokens in that list should always be included in the targets for this sniff anyway, so we may as well leverage the new token array. Includes adding the new custom `T_ENUM_CASE` token to the list of additional tokens to take into account. Includes unit test.
|
Thanks for enum case support and taking the time for the cleanup |
jrfnl
deleted the
feature/generic-lowercasekeyword-simplify-and-enum-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to simplify maintenance of this sniff.
Since PR #3484, the
Tokensclass contains a$contextSensitiveKeywordsproperty which largely overlaps with the list of tokens registered for this sniff.All tokens in that list should always be included in the targets for this sniff anyway, so we may as well leverage the new token array.
Includes adding the new custom
T_ENUM_CASEtoken to the list of additional tokens to take into account.Includes unit test.