[Hot fix] Tokenizer/PHP: 2 bug fixes for improved context sensitive keyword support #3608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in 3607, the `eval` keyword was not included in the list of context sensitive keyword. This is a regression compared to PHPCS 3.6.2. Fixed now, including unit tests. Fixes 3607
While investigating 3607, I figured adding a test with a function declared to return by reference would also not be amiss and found that that situation was not accounted for. This commit fixes that. Includes unit test.
|
@gsherwood Both of the above fixes are fixes for regressions against PHPCS 3.6.2. With that in mind, I believe this PR should still be included in PHPCS 3.7.0. |
|
Thanks so much for fixing this, and so quickly! |
jrfnl
deleted the
feature/3607-tokenizer-php-contextsensitivekeywords-bugfix
branch
Closed
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tokenizer/PHP: bug fix in improved context sensitive keyword support [1]
As reported in #3607, the
evalkeyword was not included in the list of context sensitive keyword. This is a regression compared to PHPCS 3.6.2.Fixed now, including unit tests.
Fixes #3607
Tokenizer/PHP: bug fix in improved context sensitive keyword support [2]
While investigating #3607, I figured adding a test with a function declared to return by reference would also not be amiss and found that that situation was not accounted for.
This commit fixes that.
Includes unit test.