Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented May 3, 2022

  • Current example notebooks are terribly outdated. Run them on every pull request, to stay in sync with the library.
  • Use myst-nb instead of nbsphinx (more actively developed, fewer dependency problems)
  • Exclude outdated examples for now
  • Use m2r2 instead of unmaintained m2r for markdown parsing

@codecov-commenter
Copy link

codecov-commenter commented May 3, 2022

Codecov Report

Merging #144 (5f5ffdc) into develop (0648b0c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #144   +/-   ##
========================================
  Coverage    77.73%   77.73%           
========================================
  Files           27       27           
  Lines         2906     2906           
  Branches       718      718           
========================================
  Hits          2259     2259           
  Misses         468      468           
  Partials       179      179           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0648b0c...5f5ffdc. Read the comment docs.

dweindl added a commit that referenced this pull request May 3, 2022
See #89

Also, clear notebook output to not litter the repository - will be run during doc build (#144).
@dweindl dweindl merged commit fb7f327 into develop May 3, 2022
@dweindl dweindl deleted the exec_notebooks branch May 3, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants