Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Apr 28, 2022

See #89

Also, clear notebook output to not litter the repository - will be run during doc build (#144).

@dweindl dweindl requested a review from plakrisenko April 28, 2022 14:39
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2022

Codecov Report

Merging #137 (c90fa76) into develop (a463194) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #137   +/-   ##
========================================
  Coverage    77.73%   77.73%           
========================================
  Files           27       27           
  Lines         2906     2906           
  Branches       718      718           
========================================
  Hits          2259     2259           
  Misses         468      468           
  Partials       179      179           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a463194...c90fa76. Read the comment docs.

@dweindl dweindl force-pushed the update_vis branch 2 times, most recently from 2b3ddfc to b2cd39a Compare May 2, 2022 10:40
@plakrisenko
Copy link
Member

Only small thing: the plots with an empty VS and with only 'plotId' column aren't the same as stated. In the former case there are three subplots and in the latter case everything is plotted together.

@dweindl
Copy link
Member Author

dweindl commented May 3, 2022

Only small thing: the plots with an empty VS and with only 'plotId' column aren't the same as stated. In the former case there are three subplots and in the latter case everything is plotted together.

Thanks. Updated.

@dweindl dweindl merged commit 0648b0c into develop May 3, 2022
@dweindl dweindl deleted the update_vis branch May 3, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants