Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated visualization functions #130

Merged
merged 12 commits into from
May 4, 2022
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Apr 27, 2022

Remove old visualization functions deprecated since #58.

@dweindl dweindl marked this pull request as ready for review April 27, 2022 19:19
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2022

Codecov Report

Merging #130 (b2d2b14) into develop (0648b0c) will decrease coverage by 0.55%.
The diff coverage is 86.95%.

@@             Coverage Diff             @@
##           develop     #130      +/-   ##
===========================================
- Coverage    77.73%   77.18%   -0.56%     
===========================================
  Files           27       26       -1     
  Lines         2906     2441     -465     
  Branches       718      578     -140     
===========================================
- Hits          2259     1884     -375     
+ Misses         468      404      -64     
+ Partials       179      153      -26     
Impacted Files Coverage Δ
petab/visualize/plot_data_and_simulation.py 76.66% <71.42%> (-6.67%) ⬇️
petab/visualize/plotting.py 86.05% <91.66%> (+0.04%) ⬆️
petab/visualize/__init__.py 100.00% <100.00%> (ø)
petab/visualize/helper_functions.py 78.12% <100.00%> (-4.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0648b0c...b2d2b14. Read the comment docs.

@dweindl dweindl requested review from plakrisenko and removed request for plakrisenko April 27, 2022 19:35
@dweindl
Copy link
Member Author

dweindl commented Apr 27, 2022

The example notebooks still use the old vis code?! :(

- [ ] #89
Will be disabled for now #144

@dweindl dweindl marked this pull request as draft April 28, 2022 14:14
@dweindl dweindl marked this pull request as ready for review April 29, 2022 13:07
@dweindl dweindl marked this pull request as draft April 29, 2022 13:07
@dweindl dweindl marked this pull request as ready for review May 3, 2022 11:31
@dweindl dweindl requested a review from plakrisenko May 3, 2022 11:36
@dweindl dweindl merged commit efa9edb into develop May 4, 2022
@dweindl dweindl deleted the remove_deprecated_vis branch May 4, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants