Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub CI #644

Merged
merged 18 commits into from
Feb 16, 2021
Merged

Use GitHub CI #644

merged 18 commits into from
Feb 16, 2021

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Feb 15, 2021

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
  • Documentation has been added / updated (for bug fixes / features)
  • HISTORY.rst has been updated (with summary of main changes)
  • bumpversion (major / minor / patch) has been called on this branch
  • Tags have been pushed (git push --tags)
  • What kind of change does this PR introduce?

This implements a Linux-only set of build checks using the GitHub CI actions. This is loosely based off of the recipes implemented in other supported projects (via @cehbrecht, thanks!). The builds here replicate those that we had working previously and leverages tox for all stages. Assuming that everything works relatively well out-of-the-box, we can leverage this for a handful of projects with a limited number of builds.

  • Does this PR introduce a breaking change?

No.

  • Other information:

roocs/clisops#124 (comment)

@Zeitsperre Zeitsperre added the enhancement New feature or request label Feb 15, 2021
@Zeitsperre Zeitsperre requested a review from tlvu February 15, 2021 14:59
@Zeitsperre Zeitsperre self-assigned this Feb 15, 2021
@Zeitsperre Zeitsperre added this to the v0.24 milestone Feb 15, 2021
@Zeitsperre Zeitsperre marked this pull request as draft February 15, 2021 15:00
@Zeitsperre Zeitsperre marked this pull request as ready for review February 15, 2021 17:03
Copy link

@tlvu tlvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few questions.

.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
…info, replace Travis CI basge with GH Workflow badge
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
For the doctests and slow tests, I think I would suggest removing the normal tests from the doctests suite and running the slow tests in py38. Just to reduce the load a bit more and have it a bit more consistent with the naming?

EDIT : And do we need the docs env if we keep the RTD build?

…t docs build in GH actions, restructure tox builds for multiplatform, slow build on py38
…o that black must pass before longer tests are triggered
@Zeitsperre
Copy link
Collaborator Author

This is good to merge. Thanks for the reviews @aulemahal @tlvu

@Zeitsperre Zeitsperre merged commit 2544dde into master Feb 16, 2021
@Zeitsperre Zeitsperre deleted the use_guthub_ci branch February 16, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants