-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GitHub CI #644
Use GitHub CI #644
Conversation
… module-level D400,D205 skipping when encoding is specified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few questions.
…port xml or sqlite output from pytest-cov (see: coverallsapp/github-action#15)
… test stage passing
…info, replace Travis CI basge with GH Workflow badge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
For the doctests and slow tests, I think I would suggest removing the normal tests from the doctests
suite and running the slow tests in py38
. Just to reduce the load a bit more and have it a bit more consistent with the naming?
EDIT : And do we need the docs
env if we keep the RTD build?
…t docs build in GH actions, restructure tox builds for multiplatform, slow build on py38
…o that black must pass before longer tests are triggered
This is good to merge. Thanks for the reviews @aulemahal @tlvu |
Pull Request Checklist:
bumpversion (major / minor / patch)
has been called on this branchgit push --tags
)This implements a Linux-only set of build checks using the GitHub CI actions. This is loosely based off of the recipes implemented in other supported projects (via @cehbrecht, thanks!). The builds here replicate those that we had working previously and leverages
tox
for all stages. Assuming that everything works relatively well out-of-the-box, we can leverage this for a handful of projects with a limited number of builds.No.
roocs/clisops#124 (comment)