Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub ci #124

Merged
merged 9 commits into from
Feb 15, 2021
Merged

Use GitHub ci #124

merged 9 commits into from
Feb 15, 2021

Conversation

cehbrecht
Copy link
Collaborator

@cehbrecht cehbrecht commented Feb 11, 2021

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes issue #xyz
  • Tests for the changes have been added (for bug fixes / features)
  • Documentation has been added / updated (for bug fixes / features)
  • HISTORY.rst has been updated (with summary of main changes)
  • bumpversion minor has been called on this branch
  • I have added my relevant user information to AUTHORS.md
  • What kind of change does this PR introduce?:

Feature: This PRs adds in initial ci workflow with github.

It removes the existing .travis.yml.

Travis CI was getting very slow ... this is an initial replacement. Can be improved later.

@ellesmith88
Copy link
Collaborator

I'm happy with this, does the badge need updating from travis to github actions in the readme?

@cehbrecht
Copy link
Collaborator Author

I'm happy with this, does the badge need updating from travis to github actions in the readme?

It does ... done 👍

Copy link
Collaborator

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really simple, nice.

@cehbrecht @ellesmith88 Would it be too much to keep the .travis.yml around for the macOS and Windows builds? Or perhaps we can raise an issue that Windows/macOS and Anaconda builds are still missing in the CI pipeline? An option that at least supports Anaconda and one other OS would be nice to have.

@cehbrecht
Copy link
Collaborator Author

cehbrecht commented Feb 11, 2021

Would it be too much to keep the .travis.yml around for the macOS and Windows builds? Or perhaps we can raise an issue that Windows/macOS and Anaconda builds are still missing in the CI pipeline? An option that at least supports Anaconda and one other OS would be nice to have.

@Zeitsperre @ellesmith88 at the moment I would prefer to just open an issue for the other builds. Travis CI builds take so long ...

Agree?

@ellesmith88
Copy link
Collaborator

@cehbrecht @Zeitsperre

We could have them as allowed failures in travis and have an issue for them? Its the waiting for the build for me, so they could still run and alert us to any issues but we're not waiting for them to run before making changes etc? Whatever you think is best.

Also sorry @cehbrecht I just accidentally edited your comment..!

@cehbrecht
Copy link
Collaborator Author

I have re-added travis ci ... and kept only the tests not covered by GitHub CI (macos, windows, anaconda). I have opened an issue #126 to complete GitHub CI.

@cehbrecht
Copy link
Collaborator Author

@Zeitsperre maybe we can trigger travis ci only when doing a release? Or add a travis ci cron-job run daily/weekly?

@Zeitsperre
Copy link
Collaborator

@cehbrecht @ellesmith88

Thanks for this. Yes, I think simply having them run on push is perfectly fine. The most important factor from my perspective is making sure that releases work for Windows/macOS. We'll see that on master, and thankfully the fixes are usually not too complicated.

@cehbrecht
Copy link
Collaborator Author

@Zeitsperre with type=push travis does not block the ci build and it will be triggered when merged to master? That would be good solution 😄

Ready to merge?

@Zeitsperre Zeitsperre merged commit e1995e6 into master Feb 15, 2021
@Zeitsperre Zeitsperre deleted the use-github-ci branch February 15, 2021 14:14
@Zeitsperre Zeitsperre mentioned this pull request Feb 15, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants