-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GitHub ci #124
Use GitHub ci #124
Conversation
I'm happy with this, does the badge need updating from travis to github actions in the readme? |
It does ... done 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really simple, nice.
@cehbrecht @ellesmith88 Would it be too much to keep the .travis.yml
around for the macOS and Windows builds? Or perhaps we can raise an issue that Windows/macOS and Anaconda builds are still missing in the CI pipeline? An option that at least supports Anaconda and one other OS would be nice to have.
@Zeitsperre @ellesmith88 at the moment I would prefer to just open an issue for the other builds. Travis CI builds take so long ... Agree? |
We could have them as allowed failures in travis and have an issue for them? Its the waiting for the build for me, so they could still run and alert us to any issues but we're not waiting for them to run before making changes etc? Whatever you think is best. Also sorry @cehbrecht I just accidentally edited your comment..! |
I have re-added travis ci ... and kept only the tests not covered by GitHub CI (macos, windows, anaconda). I have opened an issue #126 to complete GitHub CI. |
@Zeitsperre maybe we can trigger travis ci only when doing a release? Or add a travis ci cron-job run daily/weekly? |
Thanks for this. Yes, I think simply having them run on |
@Zeitsperre with Ready to merge? |
Pull Request Checklist:
bumpversion minor
has been called on this branchAUTHORS.md
Feature: This PRs adds in initial ci workflow with github.
It removes the existing
.travis.yml
.Travis CI was getting very slow ... this is an initial replacement. Can be improved later.
Does this PR introduce a breaking change?:
no
Other information::
Migrate from Travis-CI to GitHub Actions 34e-mngmt#81