Skip to content

Logical lanes: add street name #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2023
Merged

Logical lanes: add street name #701

merged 1 commit into from
Mar 24, 2023

Conversation

tbleher
Copy link
Contributor

@tbleher tbleher commented Jan 18, 2023

The street name is helpful when displaying the map (e.g. for navigation purposes). The street name is added to the logical lanes, since the street name will typically come from the underlying map, and most map formats are more similar to logical lanes than to physical lanes.

@ThomasNaderBMW ThomasNaderBMW added the Harmonisation The Group in the ASAM development project working on harmonisation with other standards. label Jan 19, 2023
@ThomasNaderBMW ThomasNaderBMW self-requested a review January 19, 2023 07:45
ThomasNaderBMW
ThomasNaderBMW approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@ThomasNaderBMW ThomasNaderBMW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passt auch aus meiner Sicht zu den logical lanes.
Es ist keine Eigenschaft die physisch vorliegt oder von Sensoren detektiert werden könnte.

@thomassedlmayer
Copy link
Contributor

Harmonization WG 2023/03/01: You would have to create a new lane if the streetname of a road changes. Could maybe also/instead be added to the RouteSegment proposed in #705?

@schmidtlorenz schmidtlorenz reopened this Mar 13, 2023
@ThomasNaderBMW
Copy link
Contributor

WG Other Models:
Route Segment is just a piece of the map and doesnt describe the whole map.
For us it is ok.

@ThomasNaderBMW ThomasNaderBMW added the ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. label Mar 13, 2023
@pmai pmai added ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB. and removed ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. labels Mar 13, 2023
@pmai
Copy link
Contributor

pmai commented Mar 13, 2023

CCB 2023-03-13: Merge as-is.

@tbleher @pmai
Logical lanes: add street name
9de4e56 
The street name is helpful when displaying the map (e.g. for navigation
purposes). The street name is added to the logical lanes, since the
street name will typically come from the underlying map, and most map
formats are more similar to logical lanes than to physical lanes.

Signed-off-by: Thomas Bleher <thomas.tb.bleher@bmw.de>
@pmai pmai self-assigned this Mar 13, 2023
@pmai pmai merged commit 7feecaf into OpenSimulationInterface:master Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasNaderBMW ThomasNaderBMW ThomasNaderBMW approved these changes

Assignees

@pmai pmai

Labels
Harmonisation The Group in the ASAM development project working on harmonisation with other standards. Other Models ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tbleher @thomassedlmayer @ThomasNaderBMW @pmai @schmidtlorenz