-
Notifications
You must be signed in to change notification settings - Fork 129
feat: New OSI message osi_route #705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New OSI message osi_route #705
Conversation
b164ba7
to
b807086
Compare
b807086
to
1fa02e1
Compare
Thank you @FabianPfeufferCAP ! Looks good to me. |
Feedback WG Other Models:
|
WG Other Models (2023-05-08): Waiting for minor rework of PR (see comments by @ThomasNaderBMW). Ready for CCB after next Other Models WG meeting. |
1fa02e1
to
6e666a8
Compare
WG Other Models, open questions:
|
2619496
to
a2d4d6f
Compare
The new message allows sending route information to a traffic agent in the simulation. The route information can then be used by the agent to traverse the road network. Signed-off-by: Fabian Pfeuffer <Fabian.Pfeuffer@partner.bmw.de>
Signed-off-by: Fabian Pfeuffer <Fabian.Pfeuffer@partner.bmw.de>
06e5461
to
7083ca2
Compare
Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
CCB 2024-02-12: Merge as-is. |
{ | ||
// The unique id of the route. | ||
// | ||
// \note This field is mandatory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thomassedlmayer I think we should apply the rules here: https://github.com/OpenSimulationInterface/open-simulation-interface/blob/master/rules.yml
is_set
is_globally_unique
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to put rules into a new issue and/or PR, as we would find more fields, where we would add them, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will create a new PR (see #805) an check everything for mandatory fields. We should definitely add this to v3.7.0, since I consider this a bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review v3.7.0
@PhRosenberger changes suggested
I mention #804 here |
I created a separate PR to add rules to existing comments describing rules: #806 |
Add a description
Added a new OSI message osi_route.proto to send a planned route to an agent or a device, such as a vehicle or navigation system. This route information can then be used to plan a path and traverse the road network.
Some questions to ask:
What is this change?
A new OSI feature to provide agent models with more logical data to perform path planning.
Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board: