-
Notifications
You must be signed in to change notification settings - Fork 131
Draft for discussion: Surface lines to model road shapes and heights #600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
arnedueselder
wants to merge
219
commits into
OpenSimulationInterface:master
from
arnedueselder:master
Closed
Changes from 1 commit
Commits
Show all changes
219 commits
Select commit
Hold shift + click to select a range
d1344a3
revert matrix multiplication order of rotations
cc9d146
change preferred angular ranges
d6488f2
removed cones as an example from TYPE_CONSTRUCTION_SITE_ELEMENT becau…
ca2a5a9
feat(docs): Create initial document structure (#494)
max-rosin 0edbd11
Describe installation under Linux and Windows (#518)
max-rosin 7737b0d
feat(docs): Add topics to submap (#518)
max-rosin 3a73411
Add color orange as suggested in issue #504 - Harmonization of road m…
MarcelOliver 66cf331
Added release notes for 3.3.0
vkresch e1cb86a
updated release notes for bugfix
a0d0b6d
Remove obsolete image and update release notes
pmai 61fcd4d
Initial GitHub Actions CPP ProtoBuf Build
pmai 37e75c0
Add Python ProtoBuf build
pmai f304937
add attribute country, country_revision, code and sub_code to traffic…
MarcelOliver 8c45cae
Use string for country type. For country specification see ISO 3166-1…
MarcelOliver c04587a
mark possible deprecated messages
MarcelOliver 06f5465
mark possible deprecated messages
MarcelOliver 968f976
Modified comment to mark as deprecated in a uniform way - enum actor
MarcelOliver c187f0d
Modified comment to mark as deprecated in a uniform way - enum Direction
MarcelOliver 6796cbf
Modified comment to mark as deprecated in a uniform way - type
MarcelOliver 497b438
Modified comment to mark as deprecated in a uniform way - DirectionScope
MarcelOliver 3a3a4e8
Modified comment to mark as deprecated in a uniform way - vertically_…
MarcelOliver ae5dab9
Modified comment to mark as deprecated in a uniform way - Type
MarcelOliver da96fc7
Modified comment to mark as deprecated in a uniform way - Type type
MarcelOliver 7c10aad
Modified comment to mark as deprecated in a uniform way - Actor actor
MarcelOliver 86dbd3b
Modified comment to mark as deprecated in a uniform way - Arrow arrow
MarcelOliver 9c3fc88
Modified comment to mark as deprecated in a uniform way - Type
MarcelOliver 7d39141
Modified comment to mark as deprecated in a uniform way
MarcelOliver 3a2529d
add examples for country and country_revision in comment
MarcelOliver a495167
correct example for ISO 3166-1 alpha-2 code
MarcelOliver 9274d22
better comments to clarify use of code and sub_code
MarcelOliver cbe8db4
mark Type as deprecated
MarcelOliver ef9eb25
add attribute country, country_revision, code and sub_code to roadmar…
MarcelOliver fa65516
Add a type field for custom traffic actions
caspar-ai 4daa5cc
Use a more specific field name
caspar-ai defb094
fix(docs): Fix header (#518)
max-rosin c7d7c98
Add more detail to documentation
caspar-ai 753ce64
feat(docs): Comment out includes irrelevant to v3.4
max-rosin 5b7e012
feat(docs): Comment out includes irrelevant to v3.4
max-rosin 539493a
Extension of an additional Identifier for external references
DerBaertige 6390896
Update the ExternalReference message by adding the possibility to def…
DerBaertige f299be8
First usage of ExternalReference in Lane, StationaryObject and Moving…
DerBaertige ae6986b
Remove t_road_lanes_laneSection_center_lane from the Lane::ExternalRe…
DerBaertige 274c959
External References added to TrafficSign, TrafficLight and Road Marking
DerBaertige 00f09d8
Add external reference to EnvironmentalConditions, Occupant, LaneBoun…
DerBaertige 57cb229
Correct mismatch of protobuf continuous IDs and add osi_common to osi…
DerBaertige 7713d7a
Apply suggestions from code review
DerBaertige bcb45bb
Second part from code review
DerBaertige 81e684d
Remove the version from the comment for OpenX description and use als…
DerBaertige 0483234
Update the OpenX-Examples to rDNS.
DerBaertige 8e54428
fix(docs): Doc review
max-rosin d2e700e
fix(docs): Remove stray line (#465)
max-rosin 6a3ade2
fix(docs): Align wording across files (#465)
max-rosin 40742a8
Add type speed bump to stationary object
0815-code 2c23aff
Documentation Update (fix typo + better wording)
MarcelOliver cb1ac8b
Describe top-level messages (#506)
max-rosin 2fddce9
feat(docs): Add traffic command and traffic update (#506)
max-rosin c68090d
Implement review comments (#506)
max-rosin ca22845
fix(docs): Implement changes after review (#506)
max-rosin 5d02cf6
feat(docs): Describe coordinate systems and reference points (#510)
max-rosin cf8a383
Describe trace files (#520)
max-rosin 3000542
Fix typos (#520)
max-rosin f6b6ee6
fix(docs): Fix typos, add example file name (#520)
max-rosin c518c36
fix(docs): Improve wording after review (#520)
max-rosin 6aa4d4f
feat(docs): Describe model types (#517)
max-rosin f4aa148
fix(docs): Fix typos (#517)
max-rosin 0b23bab
feat(docs): Migrate version info (#532)
max-rosin be2f0d3
fix(docs): Remove stray characters (#532)
max-rosin 60061f8
fix(docs): Fix whitespace and missing header markup (#532)
max-rosin c7324ea
feat(docs): Add architecture overview (#534)
max-rosin 8e995cc
feat(docs): Add content about interface fields as found in original d…
max-rosin 13815d0
fix(docs): Improve text quality (#534)
max-rosin fc31130
feat(docs): Add traffic command, traffic update and host vehicle data…
max-rosin 7aecc07
feat(docs): Add link to reference documentation (#531)
max-rosin 303365b
feat(docs): Add very short vision document (#540)
max-rosin d5f2133
fixed image includes and rendering with aciidoctor
7389030
Refer to OpenDRIVE, clarify deprecation intent
pmai 6c0526b
fix(docs): Implement review comments (#549)
max-rosin 0bd74a5
fix(docs): Implement review comments (#549)
max-rosin a6b6efe
fix(docs): Doc review (#549)
max-rosin 1f2ec78
fix(docs): Implement review comments (#549)
max-rosin d4f87e7
Added emitting structure for types of stationary object classes.
LukasElster b57db89
Proposal for the attributes of emitting structures.
LukasElster bfb5e85
Updated version of the emitting object message based on the discussio…
LukasElster 426c54f
New Proposal for emitting objects. Added Distribution into common for…
LukasElster c9b86aa
Minor changes in plausibility and comments.
LukasElster 282d7e6
Changes in osi_common reversed and new structure in osi_object to spe…
LukasElster 4d39b13
Minor changes due to discussion in working group.
LukasElster b023a55
Changes in the description based on the CCB review.
LukasElster 9d9b14b
Moved the distribution definition to osi_common and deleted the max_i…
LukasElster 5bf2488
change vector in global to vector in local and vice versa
3f80758
Clarified semantics currently supported with TrafficUpdate
fbccf88
Add more explanations to TrafficUpdate semantics
2a59bb2
Decapitalize one, reflow text for even widths
pmai 599849f
fix(docs): implement review comments (#549)
max-rosin 0375f2f
fix(docs): fix typo (#549)
max-rosin 1641ef9
fix(docs): implement review comments (#549)
max-rosin a849a7a
fix(docs): implement review comments (#549)
max-rosin e54ac94
fix(docs): Implement review comments (#549)
max-rosin 1e05491
Apply suggestions from code review
caspar-ai 8ee6ef8
fix(docs): Remove lorem ipsum (#549)
max-rosin bb2d258
fix(docs): Fix typos (#549)
max-rosin 70cbce9
Add packaging and data layer definition drafts
pmai d785623
Commit CCB review results for doc migration
pmai 9687c4b
Fix language issues in data and packaging layer
pmai 5a47ffe
style(docs): linguistic review (#549)
pasched da45877
Reorder sensor view configuration, fix single quotes.
pmai bb9a8a2
fix(docs): linguistic review (#549)
pasched 9230e4f
fix(doc): add data layer and packaging layer to user guide (#549)
pasched 660108f
doc review (#549)
pasched af925df
Add first draft of additional color models
thomassedlmayer db172ed
Clarify documentation of semantic colors
thomassedlmayer 863539d
Add new color fields, mark old ones as deprecated
thomassedlmayer f529853
Add color description to moving objects
thomassedlmayer 80ad515
Change unit of hue (ColorHSV) to degree
thomassedlmayer 4fb19d6
Add color description to traffic light
thomassedlmayer fbaf376
Add color description to lane boundaries
thomassedlmayer 24c0217
Add color description to road markings
thomassedlmayer 1b8dc76
Relocate color description fields
thomassedlmayer 46a2bdd
Add brief tag and remove spaces
thomassedlmayer 9a0c107
Add osi3 and pyproject.toml to .gitignore
yanqd0 d88b8ac
Add StationaryObjectClassification including assigned_lane_id and ass…
0815-code 6f83cff
Move assigned_lane_id and assigned_lane_percentage under Classificati…
0815-code c763e89
Apply suggestions from documentation review
pmai 068e24a
Fix field numbering conflict with master
pmai b6ed9ad
Add support for flatbuffers code generation
pmai d369e5a
Fix include and source file distribution issues
pmai 0f037a1
Fix missing protobuf include path for flatc conversion
pmai 4106ca1
Add dash property to boundary points
thomassedlmayer 933943d
Add UNKNOWN and OTHER to dash enum
thomassedlmayer ed3e62d
Minor wording update from documentation review
pmai d3c78d1
docs: native speaker review
pasched 0ef1295
docs: reverted changes in release notes
pasched 24e0337
included native speaker review in versioning chapter
6d59951
OpenSimulationInterface/osi-documentation#43 replace world with globa…
4c488f0
Added bibliography entries. Relates to OpenSimulationInterface/osi-se…
FKlopfer 61bd591
Added initial pictures for the WIP surfacelines
arnedueselder 9d3b003
Update osi_lane.proto
arnedueselder 00f6191
Adjusted surfaceline points
arnedueselder 9ec4b23
Add flag to filter static content from sensorview
pmai 5934e45
Adjust static flag description to be more precise
pmai 7e83d6e
echo_pulse_width added in osi_featuredata.proto for message LidarDete…
PhRosenberger 7669564
Explanation and reference with figures added.
PhRosenberger 183f41b
Fixed indentation that used tabs instead of spaces
cb582ae
Linguistic review
FKlopfer 852e9a1
correct citation for external source
2310498
New Branch and update of the necessary changes from PR "Extension of …
ThomasNaderBMW d1dd585
Updated motor descriptions.
ThomasNaderBMW a6d3fb9
Updated VehicleLocalization after CCB
ThomasNaderBMW 9231a32
Added geodetic position
ThomasNaderBMW bd1794d
Linguistic review
FKlopfer 60e1ad2
Added VehicleBrakeSystem and changed to VehicleSteering
ThomasNaderBMW 02f85be
Added host vehicle id and minor description modifications.
ThomasNaderBMW 0d5fd2d
Minor clarifications and language corrections
pmai ab3c0f0
Doc: changed code highlighting of install commands
bec8589
adjusted linking method
pasched ca3c84b
moved versioning.adoc to osi-documentation
pasched 77c6bd9
docs: revise message formatting
pasched 9ba7c77
docs: revise message formatting (continued)
pasched 2041a04
docs: exclude versioning.adoc in map, moved to osi-documentation
pasched 200200a
docs: excluded release notes
pasched 2528482
feat: Extend laneboundary types with additional types from OpenDRIVE
HendrikAmelunxen 1fc4d01
Removed poles (should be handled as TYPE_STRUCTURE)
HendrikAmelunxen e618970
Removed railing type; extended description for barrier-type.
HendrikAmelunxen 07f4708
docs: removed chapter with link to reference doc, to be inserted in d…
pasched d55c674
restructured modeling a traffic participant
c1ec689
doc: small fix to rendering of install steps
05532c6
doc: fix of naming of standard
dd9b548
fix(docs): corrected vector from rear axis to sensor mounting point (…
paagkame a8622fe
Description Corrections. (#595)
ThomasNaderBMW dd91128
Prepare Release of 3.4 (#598)
cb7ac9d
Update osi_lane.proto
arnedueselder 3c355a1
Update osi_lane.proto
arnedueselder c434fbf
Create proto_surfaceline
arnedueselder 3eb4db6
Update osi_lane.proto
arnedueselder 8acaf1b
Create osi_surfaceline.proto
arnedueselder 30c8dac
Delete proto_surfaceline
arnedueselder e78e56c
Update osi_surfaceline.proto
arnedueselder cb6e916
Update osi_surfaceline.proto
arnedueselder 7393cd6
Update osi_surfaceline.proto
arnedueselder 79fccb5
Update osi_surfaceline.proto
arnedueselder 2b1088a
Update osi_surfaceline.proto
arnedueselder 352f3cf
Update osi_surfaceline.proto
arnedueselder 65e7045
Update osi_surfaceline.proto
arnedueselder 9d3dff7
Update osi_lane.proto
arnedueselder d133502
docs: exclude versioning.adoc in map, moved to osi-documentation
pasched fa92731
docs: excluded release notes
pasched 876d45a
Update osi_lane.proto
arnedueselder b0a99ad
Create proto_surfaceline
arnedueselder 00c3252
Update osi_lane.proto
arnedueselder ded7a43
Create osi_surfaceline.proto
arnedueselder 3785cb3
Delete proto_surfaceline
arnedueselder 7616568
Update osi_surfaceline.proto
arnedueselder 328c0b7
Update osi_surfaceline.proto
arnedueselder 6428610
Update osi_surfaceline.proto
arnedueselder 5abdfb3
Update osi_surfaceline.proto
arnedueselder 76ab09a
Update osi_surfaceline.proto
arnedueselder b8e3304
Update osi_surfaceline.proto
arnedueselder e1cc5b1
Update osi_surfaceline.proto
arnedueselder e265b8b
Update osi_surfaceline.proto
arnedueselder 35def40
Update osi_surfaceline.proto
arnedueselder 5da4fec
Update osi_surfaceline.proto
arnedueselder 90bd591
Add automated driving function state to host vehicle data (#589)
caspar-ai 0fc0b9a
Add dash gap enum
thomassedlmayer 471c9ea
Refine gap enum description
thomassedlmayer d38625c
Update comment for DASH_GAP
thomassedlmayer b9abd16
Remove protobuf version mention in README
jdsika f6be831
Tweak Doxygen output
tbleher c3340e3
Update osi_surfaceline.proto
arnedueselder f402f0a
Add TYPE_TRUCK to vehicle classifications
caspar-ai f1df576
Clarify OSC <-> OSI mapping for vehicle types
caspar-ai 59f9ebc
Add placeholder for OSI/OSC divergence reason
caspar-ai a6d83ee
Clarify tram and train mappings
caspar-ai bf3e1d4
Fix typos based on review
caspar-ai 1805a9f
Simplify comments
caspar-ai 7445239
Remove direct comparisons to OSC
caspar-ai 05b7424
Remove last OSC reference
caspar-ai 4b59099
Documentation images (#585)
8e81f5d
Reference images in comments
caspar-ai 81f23da
Add smaller black-line images
caspar-ai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update osi_surfaceline.proto
Added more \brief sections for every message Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
- Loading branch information
commit 35def40ab4b6494e13e34823c4feae18a69866fd
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As written above, I think the Lane should reference the surface line and not vice versa. Fits better to the current schema of lanes referencing lane boundaries.