-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft for discussion: Surface lines to model road shapes and heights #600
Closed
arnedueselder
wants to merge
219
commits into
OpenSimulationInterface:master
from
arnedueselder:master
Closed
Draft for discussion: Surface lines to model road shapes and heights #600
arnedueselder
wants to merge
219
commits into
OpenSimulationInterface:master
from
arnedueselder:master
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discussions from Meeting at 22.11.2021:
Enums for new variables should be added at the end to be backwards compatible. |
clemenshabedank
added
the
RoadModel4.0
A label to collect road model topics for OSI 4.0
label
Nov 23, 2021
6 tasks
Signed-off-by: Julian Schmidt <bosch.j.schmidt@extaccount.com> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Julian Schmidt <bosch.j.schmidt@extaccount.com> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
…se there is a separate TYPE_PYLON Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Maximilian Rosin <maximilian.rosin@parson-europe.com> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Maximilian Rosin <maximilian.rosin@parson-europe.com> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Maximilian Rosin <maximilian.rosin@parson-europe.com> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
…ark colors with OpenDRIVE Signed-off-by: Pierre R. Mai <pmai@pmsf.de> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Viktor Kreschenski <viktor.kreschenski@altran.com> Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Stefan Cyliax <stefan.cyliax@asam.net> Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Pierre R. Mai <pmai@pmsf.de> Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Pierre R. Mai <pmai@pmsf.de> Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Pierre R. Mai <pmai@pmsf.de> Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
… sign classification (mainSign and supplementarySign Signed-off-by: Marcel Sachse <msachse@pmsfit.de> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
…, alpha-2 codes. Signed-off-by: Marcel Sachse <msachse@pmsfit.de> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Marcel Sachse <msachse@pmsfit.de> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Marcel Sachse <msachse@pmsfit.de> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Marcel Sachse <msachse@pmsfit.de> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Marcel Sachse <msachse@pmsfit.de> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: def4ke <f4ke@projectphoenix.de> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Adjusted explanations and clean up Signed-off-by: def4ke <f4ke@projectphoenix.de> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: def4ke <f4ke@projectphoenix.de> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Added sections to change the number of surface lines Signed-off-by: def4ke <f4ke@projectphoenix.de> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: def4ke <f4ke@projectphoenix.de> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: def4ke <f4ke@projectphoenix.de> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: def4ke <f4ke@projectphoenix.de> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Added brief description and references to appropriate lines as suggested Signed-off-by: Arne Düselder <arne.dueselder@fka.de> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Added more \brief sections for every message Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Fixed typos Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
* Add driver assist to host vehicle data Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai> * Feedback from review Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai> * Make the structure more generic to all automated driving Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai> * Code review mark-ups Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai> * Split out driver override To remove complexity and confusion from the state enum. Also remove redundant prefixes for fields and enums. Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai> * small change Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp> * Doc: fix reference style for links Signed-off-by: Stefan Cyliax <stefan.cyliax@asam.net> Co-authored-by: clemenshabedank <clemens.habedank@partner.bmw.de> Co-authored-by: Stefan Cyliax <stefan.cyliax@asam.net> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Pierre R. Mai <pmai@pmsf.de> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
- Automatically generate brief output, so the attribute list is more informative. - Do not sort detailed description alphabetically. This means the detailed description is in the same order as the attribute list and the source file. - Translate \rules and \endrules to something more readable. As a nice side effect, this removes a lot of warnings when building the documentation. Signed-off-by: Thomas Bleher <thomas.tb.bleher@bmw.de> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com> First changes according to last meetings feedback Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
To align with OpenSCENARIO and OpenLABEL. Also deprecate the use of TYPE_HEAVY_TRUCK and TYPE_SEMITRAILER as ambiguous. Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Specifically removing renaming of heavy-truck -> truck and defining the mapping instead. Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Specifically regarding the mapping from OSC 2.x. Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Don't attempt to provide precise ways of distinguishing between types at this stage. Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Markus Waldmann <Markus.Waldmann@stud.hs-kempten.de> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai> Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Closing in favor of #619. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surface lines concept as proposed in the OSI Road Network Model Group
First draft on how to implement the surface line concept in OSI. As discussed, the approach follows the concept of Vector3D line segments that form a lane and are used to retrieve height information at different parts of that lane.
Speed bumps etc. could be modelled with more points, while almost flat surfaces would require none or almost none surface lines at all.
Height information of lane boundaries should be also included. The concept should only be used for a very rough description of the height profile and not used for a very detailed description of the road surface.
It would replace the currently implemented centerline for now (but not necessarily). The intend is to separate physical properties from logical information. It would still be possible though to place a surface line in the center of the lane to keep that information.
Concept will be expanded to be used in junctions, but is still open for discussion within the concept group.