Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft for discussion: Surface lines to model road shapes and heights #600

Closed
wants to merge 219 commits into from

Conversation

arnedueselder
Copy link

Surface lines concept as proposed in the OSI Road Network Model Group

First draft on how to implement the surface line concept in OSI. As discussed, the approach follows the concept of Vector3D line segments that form a lane and are used to retrieve height information at different parts of that lane.
Speed bumps etc. could be modelled with more points, while almost flat surfaces would require none or almost none surface lines at all.

Height information of lane boundaries should be also included. The concept should only be used for a very rough description of the height profile and not used for a very detailed description of the road surface.
It would replace the currently implemented centerline for now (but not necessarily). The intend is to separate physical properties from logical information. It would still be possible though to place a surface line in the center of the lane to keep that information.

Concept will be expanded to be used in junctions, but is still open for discussion within the concept group.

@arnedueselder
Copy link
Author

Discussions from Meeting at 22.11.2021:

  • If more than one surface line exists they should maybe contain an equal number of points along the lane to make indexing positions easier.
  • That would probably mean also that either lane boundaries should be sampled the same or that a lane boundary also contains its own surface line with the appropriate number of total points.
  • Approximation definition for the current centerline should be expanded and applied also for height information to minimize errors between to points.
  • Surface lines possibly are better placed within logical lanes instead of lanes Logical Lanes in OSI #599

Enums for new variables should be added at the end to be backwards compatible.

@clemenshabedank clemenshabedank added the RoadModel4.0 A label to collect road model topics for OSI 4.0 label Nov 23, 2021
@thomassedlmayer
Copy link
Contributor

Maybe we would also like to describe the transition from a road surface to an elevated sidewalk with this approach.

In order to describe the curb elevation using the current surface concept we would have to define another right- or left-adjacent surface line (or lane boundary) which is located above the bottom lane boundary. Is this a good way to define it?

Also, there is a height parameter for each BoundaryPoint of a lane boundary, which already defines some vague height of curbs (height ≠ z-coordinate). There is no definition of its "direction vector" though (e.g. perpendicular to some surface that does not exist yet?). We should probably think about some precise specification there. Maybe it could be used for the surface concept?
image

osi_lane.proto Outdated Show resolved Hide resolved
osi_lane.proto Outdated Show resolved Hide resolved
osi_lane.proto Outdated Show resolved Hide resolved
osi_lane.proto Outdated Show resolved Hide resolved
osi_lane.proto Outdated Show resolved Hide resolved
osi_lane.proto Outdated Show resolved Hide resolved
osi_surfaceline.proto Show resolved Hide resolved
osi_surfaceline.proto Show resolved Hide resolved
Julian Schmidt and others added 18 commits March 10, 2022 16:47
Signed-off-by: Julian Schmidt <bosch.j.schmidt@extaccount.com>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Julian Schmidt <bosch.j.schmidt@extaccount.com>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
…se there is a separate TYPE_PYLON

Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Maximilian Rosin <maximilian.rosin@parson-europe.com>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Maximilian Rosin <maximilian.rosin@parson-europe.com>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Maximilian Rosin <maximilian.rosin@parson-europe.com>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
…ark colors with OpenDRIVE

Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Viktor Kreschenski <viktor.kreschenski@altran.com>
Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Stefan Cyliax <stefan.cyliax@asam.net>
Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
… sign classification (mainSign and supplementarySign

Signed-off-by: Marcel Sachse <msachse@pmsfit.de>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
…, alpha-2 codes.

Signed-off-by: Marcel Sachse <msachse@pmsfit.de>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Marcel Sachse <msachse@pmsfit.de>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Marcel Sachse <msachse@pmsfit.de>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Marcel Sachse <msachse@pmsfit.de>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Marcel Sachse <msachse@pmsfit.de>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
arnedueselder and others added 28 commits March 10, 2022 16:51
Signed-off-by: def4ke <f4ke@projectphoenix.de>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Adjusted explanations and clean up

Signed-off-by: def4ke <f4ke@projectphoenix.de>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: def4ke <f4ke@projectphoenix.de>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Added sections to change the number of surface lines

Signed-off-by: def4ke <f4ke@projectphoenix.de>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: def4ke <f4ke@projectphoenix.de>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: def4ke <f4ke@projectphoenix.de>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: def4ke <f4ke@projectphoenix.de>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Added brief description and references to appropriate lines as suggested

Signed-off-by:  Arne Düselder <arne.dueselder@fka.de>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Added more \brief sections for every message

Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Fixed typos

Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
* Add driver assist to host vehicle data

Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai>

* Feedback from review

Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai>

* Make the structure more generic to all automated driving

Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai>

* Code review mark-ups

Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai>

* Split out driver override

To remove complexity and confusion from the state enum.

Also remove redundant prefixes for fields and enums.

Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai>

* small change

Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp>

* Doc: fix reference style for links

Signed-off-by: Stefan Cyliax <stefan.cyliax@asam.net>

Co-authored-by: clemenshabedank <clemens.habedank@partner.bmw.de>
Co-authored-by: Stefan Cyliax <stefan.cyliax@asam.net>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
- Automatically generate brief output, so the attribute list is more
  informative.
- Do not sort detailed description alphabetically. This means the detailed
  description is in the same order as the attribute list and the source
  file.
- Translate \rules and \endrules to something more readable. As a nice
  side effect, this removes a lot of warnings when building the
  documentation.

Signed-off-by: Thomas Bleher <thomas.tb.bleher@bmw.de>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>

First changes according to last meetings feedback

Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
To align with OpenSCENARIO and OpenLABEL.  Also deprecate the use
of TYPE_HEAVY_TRUCK and TYPE_SEMITRAILER as ambiguous.

Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Specifically removing renaming of heavy-truck -> truck and defining the mapping instead.

Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Specifically regarding the mapping from OSC 2.x.

Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Don't attempt to provide precise ways of distinguishing between types at this stage.

Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Markus Waldmann <Markus.Waldmann@stud.hs-kempten.de>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai>
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
@clemenshabedank
Copy link
Contributor

Closing in favor of #619.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RoadModel4.0 A label to collect road model topics for OSI 4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.