Skip to content

Proposal for discussion: Add more detailed lane information to MovingObject #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tbleher
Copy link
Contributor

@tbleher tbleher commented Sep 30, 2021

Rationale: currently there is some lane information in OSI, but simple
requests like "what is the next vehicle on my lane" still require a lot
of calculations. This makes writing agent models unnecessarily hard.

Simulation environment usually already have all the required information
(since they already need to calculate assigned_lane_id and
assigned_lane_percentage). By providing this information directly, a lot
of code and calculation time can be removed e.g. from agent models.

The information is lightweight: three doubles per moving object. No
additional fields are needed for lanes. All lanes for which this
information is needed must have a center line, but OSI can be configured
to transmit all this static information at initialization time.

This is currently a breaking change, designed for 4.0.
It could be made compatible for 3.5 if desired.

This is a proposal for discussion.

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

  • My suggestion follows the style and contributors guidelines.
  • I have taken care about the documentation.
  • I have done the DCO signoff.
  • My changes generate no errors when passing CI tests.
  • I have successfully implemented and tested my fix/feature locally.
  • Appropriate reviewer(s) are assigned.

If you can’t check all of them, please explain why.
If all boxes are checked or commented and you have achieved at least one positive review, you can assign the label ReadyForCCBReview!

Rationale: currently there is some lane information in OSI, but simple
requests like "what is the next vehicle on my lane" still require a lot
of calculations. This makes writing agent models unnecessarily hard.

Simulation environment usually already have all the required information
(since they already need to calculate assigned_lane_id and
assigned_lane_percentage). By providing this information directly, a lot
of code and calculation time can be removed e.g. from agent models.

The information is lightweight: three doubles per moving object. No
additional fields are needed for lanes. All lanes for which this
information is needed must have a center line, but OSI can be configured
to transmit all this static information at initialization time.

This is currently a breaking change, designed for 4.0.
It could be made compatible for 3.5 if desired.
@clemenshabedank
Copy link
Contributor

@ThomasSchloemicherAVL you might have an opinion on this.

@0815-code
Copy link
Contributor

0815-code commented Oct 11, 2021

@clemenshabedank @tbleher
In fact i do. Fixing #368 and #490 where steps in this directions. #507 is missing. With all three i think we can have the functionality as desired above.

@tbleher
Copy link
Contributor Author

tbleher commented Feb 6, 2022

This is obsoleted by the much more comprehensive approach in PR #599.

@tbleher tbleher closed this Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving direction information in moving object classification Add lane association capability for static objects (same as for moving objects)
3 participants