add StationaryObjectClassification including assigned_lane_id and ass… #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0815-code
force-pushed
the
feature/tp/add_static_object_lane_association_#490
branch
from
bf63cf6 to
18e3922
Compare
0815-code
added
FeatureRequest
0815-code
added
the
ReadyForCCBReview
kmeids
reviewed
May 12, 2021
osi_object.proto
Outdated
| @@ -40,6 +40,32 @@ message StationaryObject | |||
| // | |||
| optional string model_reference = 4; | |||
|
|
|||
| // Specific information about the classification of stationary objects. | |||
| // | |||
| optional StationaryObjectClassification stationary_object_classification = 5; | |||
There was a problem hiding this comment.
@ThomasSchloemicherAVL All fields should move under "Classification" message that is already available.
There was a problem hiding this comment.
@kmeids done! Sorry, must have overlooked that.
kmeids
removed
the
ReadyForCCBReview
0815-code
force-pushed
the
feature/tp/add_static_object_lane_association_#490
branch
3 times, most recently
from
c21dd53 to
275d0b2
Compare
0815-code
added
the
ReadyForCCBReview
|
CCB Output 21.07.2021
|
kmeids
added
Documentation
max-rosin
reviewed
Jul 23, 2021
max-rosin
reviewed
Jul 23, 2021
max-rosin
reviewed
Jul 23, 2021
max-rosin
reviewed
Jul 23, 2021
max-rosin
reviewed
Jul 23, 2021
|
CCB Meeting 04.08.2021:
|
pmai
approved these changes
Sep 8, 2021
…igned_lane_percentage Signed-off-by: Schloemicher, Thomas AVL,AT <thomas.schloemicher@avl.com>
…on message that is already available Signed-off-by: Schloemicher, Thomas AVL,AT <thomas.schloemicher@avl.com>
Co-authored-by: max-rosin <62103539+max-rosin@users.noreply.github.com> Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
pmai
force-pushed
the
feature/tp/add_static_object_lane_association_#490
branch
from
6d8b6d2 to
9933f4c
Compare
Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…igned_lane_percentage
#### Reference to a related issue in the repository
Add a reference to a related issue in the repository.
Add a description
Add a description of the changes proposed in the pull request.
Some questions to ask:
What is this change?
What does it fix?
Is this a bug fix or a feature? Does it break any existing functionality or force me to update to a new version?
How has it been tested?
Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:
If you can’t check all of them, please explain why.
If all boxes are checked or commented and you have achieved at least one positive review, you can assign the label ReadyForCCBReview!