app: json_requests feature #3110
Conversation
app/eth2wrap/eth2wrap.go
Outdated
| eth2http.WithAllowDelayedStart(true), | ||
| } | ||
|
|
||
| if featureset.Enabled(featureset.JSONRequests) { |
There was a problem hiding this comment.
I think you can pass the result of Enabled to WithEnforceJSON, avoiding the if statement entirely
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3110 +/- ##
==========================================
- Coverage 56.85% 56.82% -0.04%
==========================================
Files 208 208
Lines 29148 29153 +5
==========================================
- Hits 16571 16565 -6
- Misses 10740 10751 +11
Partials 1837 1837 ☔ View full report in Codecov by Sentry. |
| _ = x[enable-9223372036854775807] | ||
| _ = x[disable-0] |
There was a problem hiding this comment.
What is the purpose of those two? Disable I can understand - if we want to disable the feature later on, but enable?
There was a problem hiding this comment.
That file is auto generated by stringer
pinebit
added
the
merge when ready
Add `WithEnforceJSON(true)` parameter when `json_requests` feature is enabled in `featureset`. This is needed for Nimbus BN to properly handle SubmitProposal requests. category: feature ticket: #3108 feature_flag: json_requests
Add
WithEnforceJSON(true)parameter whenjson_requestsfeature is enabled infeatureset.This is needed for Nimbus BN to properly handle SubmitProposal requests.
category: feature
ticket: #3108
feature_flag: json_requests