app/obolapi: specify HTTP requests timeout #3098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinebit
approved these changes
May 23, 2024
Allow users of `app/obolapi` to specify HTTP requests timeout. As a result of this feature, add the `--publish-timeout` CLI flag to `exit` and `dkg` commands.
gsora
force-pushed
the
gsora/publish-cli-timeout
branch
from
859df7f
to
7b2de52
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3098 +/- ##
==========================================
+ Coverage 56.80% 56.82% +0.02%
==========================================
Files 208 208
Lines 29104 29143 +39
==========================================
+ Hits 16532 16561 +29
- Misses 10733 10742 +9
- Partials 1839 1840 +1 ☔ View full report in Codecov by Sentry. |
OisinKyne
approved these changes
May 24, 2024
Co-authored-by: Oisín Kyne <4981644+OisinKyne@users.noreply.github.com>
Co-authored-by: Oisín Kyne <4981644+OisinKyne@users.noreply.github.com>
|
KaloyanTanev
approved these changes
May 27, 2024
gsora
added
the
merge when ready
KaloyanTanev
pushed a commit
that referenced
this pull request
Jun 5, 2024
Allow users of `app/obolapi` to specify HTTP requests timeout. As a result of this feature, add the `--publish-timeout` CLI flag to `exit` and `dkg` commands. category: feature ticket: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users of
app/obolapito specify HTTP requests timeout.As a result of this feature, add the
--publish-timeoutCLI flag toexitanddkgcommands.category: feature
ticket: none