Refines zone identifiers and handling of zones with the same name #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codefromthecrypt
changed the title
codefromthecrypt
force-pushed
the
adrian.zone-qualifiers
branch
3 times, most recently
from
6ad96a4
to
52700cf
Compare
|
polished and added live test for contract of Zone.Identification |
|
NetflixOSS » denominator » denominator-pull-requests #98 SUCCESS |
codefromthecrypt
force-pushed
the
adrian.zone-qualifiers
branch
from
52700cf
to
99ed22d
Compare
Before this change, `Zone.id()` implied that the provider supported multiple zones with the same name. This turned out to be false, as for example both CloudDNS and Designate use ids, but enforce zone names must be unique. This change introduces a series of changes to support both determining how zones are identified, as well if the provider supports zones that have the same name. One goal was to not add complexity. The overall approach to this is to only add a concept while removing one. `Zone.qualifier()` is added to disambiguate zones with the same name. This is paid for by deprecating `Zone.idOrName()`. `Provider.zoneIdentification()` is added to that callers can understand if zone names can be substituted for ids or if qualifiers are supported. This is paid for by deprecating `Provider.supportsDuplicateZoneNames()`.
|
NetflixOSS » denominator » denominator-pull-requests #99 SUCCESS |
codefromthecrypt
pushed a commit
that referenced
this pull request
Mar 24, 2015
Refines zone identifiers and handling of zones with the same name
codefromthecrypt
pushed a commit
that referenced
this pull request
Mar 28, 2015
`Zone.Identifier` doesn't pull its weight. The only thing it adds beyond `Provider.supportsDuplicateZones`, is that it can indicate a zone id is the same as its name. This isn't enough to warrant the added complexity. see #350
Merged
codefromthecrypt
pushed a commit
that referenced
this pull request
Mar 28, 2015
`Zone.Identifier` doesn't pull its weight. The only thing it adds beyond `Provider.supportsDuplicateZones`, is that it can indicate a zone id is the same as its name. This isn't enough to warrant the added complexity. see #350
codefromthecrypt
pushed a commit
that referenced
this pull request
Mar 29, 2015
`Zone.Identifier` doesn't pull its weight. The only thing it adds beyond `Provider.supportsDuplicateZones`, is that it can indicate a zone id is the same as its name. This isn't enough to warrant the added complexity. see #350
codefromthecrypt
pushed a commit
that referenced
this pull request
Mar 29, 2015
`Zone.Identifier` doesn't pull its weight. The only thing it adds beyond `Provider.supportsDuplicateZones`, is that it can indicate a zone id is the same as its name. This isn't enough to warrant the added complexity. see #350
codefromthecrypt
pushed a commit
that referenced
this pull request
Mar 29, 2015
Zone.qualifier was only introduced to support creation of Route53 hosted zones. We were using this for the caller reference. Turns out that caller references can never be reused. This means that if you delete a zone, you can never create a new one with the same caller reference. As such, we shouldn't expose this to users. see #350
Merged
codefromthecrypt
pushed a commit
that referenced
this pull request
Mar 30, 2015
Zone.qualifier was only introduced to support creation of Route53 hosted zones. We were using this for the caller reference. Turns out that caller references can never be reused. This means that if you delete a zone, you can never create a new one with the same caller reference. As such, we shouldn't expose this to users. see #350
MisterK
pushed a commit
to MisterK/denominator
that referenced
this pull request
Apr 26, 2015
`Zone.Identifier` doesn't pull its weight. The only thing it adds beyond `Provider.supportsDuplicateZones`, is that it can indicate a zone id is the same as its name. This isn't enough to warrant the added complexity. see Netflix#350
MisterK
pushed a commit
to MisterK/denominator
that referenced
this pull request
Apr 26, 2015
Zone.qualifier was only introduced to support creation of Route53 hosted zones. We were using this for the caller reference. Turns out that caller references can never be reused. This means that if you delete a zone, you can never create a new one with the same caller reference. As such, we shouldn't expose this to users. see Netflix#350
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change,
Zone.id()implied that the provider supportedmultiple zones with the same name. This turned out to be false, as for
example both CloudDNS and Designate use ids, but enforce zone names
must be unique.
This change introduces a series of changes to support both determining
how zones are identified, as well if the provider supports zones that
have the same name.
One goal was to not add complexity. The overall approach to this is to
only add a concept while removing one.
Zone.qualifier()is added to disambiguate zones with the same name.This is paid for by deprecating
Zone.idOrName().Provider.zoneIdentification()is added to that callers can understandif zone names can be substituted for ids or if qualifiers are supported.
This is paid for by deprecating
Provider.supportsDuplicateZoneNames().Here are the details of this change:
Zone.qualifier()in support duplicate zonessupportsDuplicateZoneNames()in favor ofProvider.zoneIdentification()inNAME,OPAQUEandQUALIFIEDZone.idOrName()asZone.id()cannot be nullZoneApi.iterateByName()to support lookups-nparameter to CLI zone listSee https://groups.google.com/forum/#!topic/denominator-dev/X_yjoykCReU
Live tests succeeded on all providers. CLI manually tested on all providers.