Reverts Zone.qualifier #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zone.qualifier was only introduced to support creation of Route53 hosted zones. We were using this for the caller reference. Turns out that caller references can never be reused. This means that if you delete a zone, you can never create a new one with the same caller reference. As such, we shouldn't expose this to users. see #350
|
CLI zone list and live tests pass for route53 |
|
failure is due to github DDOS I think. http://www.traviscistatus.com/incidents/tfk72kps8l7g |
codefromthecrypt
pushed a commit
that referenced
this pull request
Mar 30, 2015
Reverts Zone.qualifier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zone.qualifier was only introduced to support creation of Route53 hosted
zones. We were using this for the caller reference. Turns out that
caller references can never be reused. This means that if you delete a
zone, you can never create a new one with the same caller reference. As
such, we shouldn't expose this to users.
see #350