Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refines zone identifiers and handling of zones with the same name #350

Merged
merged 1 commit into from
Mar 24, 2015

Commits on Mar 24, 2015

  1. Refines zone identifiers and handling of zones with the same name

    Before this change, `Zone.id()` implied that the provider supported
    multiple zones with the same name. This turned out to be false, as for
    example both CloudDNS and Designate use ids, but enforce zone names
    must be unique.
    
    This change introduces a series of changes to support both determining
    how zones are identified, as well if the provider supports zones that
    have the same name.
    
    One goal was to not add complexity. The overall approach to this is to
    only add a concept while removing one.
    
    `Zone.qualifier()` is added to disambiguate zones with the same name.
    This is paid for by deprecating `Zone.idOrName()`.
    
    `Provider.zoneIdentification()` is added to that callers can understand
    if zone names can be substituted for ids or if qualifiers are supported.
    This is paid for by deprecating `Provider.supportsDuplicateZoneNames()`.
    Adrian Cole committed Mar 24, 2015
    Configuration menu
    Copy the full SHA
    99ed22d View commit details
    Browse the repository at this point in the history