Skip to content

Conversation

@AdamTadeusz
Copy link
Contributor

Description

Changes in neoAssets

Adds an option for a dynamic crosshair. Depending on the type of dynamic crosshair chosen, different parts of the crosshair will grow and shrink with the player accuracy.

Adds an option to show accuracy when using scoped weapons. The same offset used in the normal crosshair is used to draw two more scopes inside the scope view.

Adds an option for a hip fire crosshair for testing

Linked Issues

@AdamTadeusz AdamTadeusz marked this pull request as draft May 20, 2025 13:53
@AdamTadeusz
Copy link
Contributor Author

I'm determined to figure out this fov business before I open this up to be reviewed

@AdamTadeusz AdamTadeusz marked this pull request as ready for review May 20, 2025 17:16
@AdamTadeusz AdamTadeusz requested a review from a team May 20, 2025 17:16
@AdamTadeusz AdamTadeusz added the Changes in neoAssets This PR depends on changes in the neoAssets repository. The relevant PR should be in the description label May 20, 2025
@AdamTadeusz AdamTadeusz marked this pull request as draft June 10, 2025 12:02
@AdamTadeusz AdamTadeusz marked this pull request as ready for review June 10, 2025 13:01
Copy link
Collaborator

@nullsystem nullsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, may want to hold this off till after networked crosshair as that has changed hud_crosshair and settings.

@AdamTadeusz
Copy link
Contributor Author

@Rainyan @nullsystem as a compromise I added the hip fire crosshair to the crosshair settings page and disabled it by default, that way it should be obvious that the feature exists to people who haven't heard about the feature once they check that page, and people who don't like it don't see it by default. I think this should give us a good enough environment for testing the feature out

@AdamTadeusz AdamTadeusz requested a review from nullsystem August 23, 2025 14:10
Rainyan
Rainyan previously approved these changes Aug 26, 2025
Rainyan
Rainyan previously approved these changes Aug 27, 2025
Copy link
Collaborator

@Rainyan Rainyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rainyan Rainyan requested a review from sunzenshen August 27, 2025 12:25
@Rainyan
Copy link
Collaborator

Rainyan commented Aug 27, 2025

Oh whoops, apologies for the triple review request 😅

sunzenshen
sunzenshen previously approved these changes Aug 28, 2025
Copy link
Contributor

@sunzenshen sunzenshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out the different dynamic crosshair types and lgtm.

@AdamTadeusz
Copy link
Contributor Author

@nullsystem Am I good to merge, can update crosshair version closer to when we know next version number?

@sunzenshen
Copy link
Contributor

sunzenshen commented Aug 28, 2025

It would also be interesting to change the bot crosshairs to be a dynamic one, to advertise the feature to new players, but that's possibly a subjective opinion. (not parity)

@Rainyan
Copy link
Collaborator

Rainyan commented Aug 30, 2025

It would also be interesting to change the bot crosshairs to be a dynamic one, to advertise the feature to new players, but that's possibly a subjective opinion. (not parity)

Bikeshedding, but IMO bots should ideally display the crosshair that the player has chosen as their preference, rather than being replicated.

@AdamTadeusz
Copy link
Contributor Author

It would also be interesting to change the bot crosshairs to be a dynamic one, to advertise the feature to new players, but that's possibly a subjective opinion. (not parity)

Bikeshedding, but IMO bots should ideally display the crosshair that the player has chosen as their preference, rather than being replicated.

Since we have the bot profiles PR branch open, we could add some personalized crosshairs to all the bots. I don't know if the original devs would be interested in hopping on and making a crosshair for themselves though

@AdamTadeusz
Copy link
Contributor Author

@nullsystem

@AdamTadeusz AdamTadeusz merged commit cde00ab into NeotokyoRebuild:master Sep 21, 2025
7 checks passed
@AdamTadeusz AdamTadeusz deleted the 235_dynamicCrosshair branch September 21, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes in neoAssets This PR depends on changes in the neoAssets repository. The relevant PR should be in the description

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Custom crosshair - Dynamic crosshair

4 participants