-
Notifications
You must be signed in to change notification settings - Fork 20
Dynamic Crosshair #1159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic Crosshair #1159
Conversation
|
I'm determined to figure out this fov business before I open this up to be reviewed |
nullsystem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, may want to hold this off till after networked crosshair as that has changed hud_crosshair and settings.
Also conform to hungarian notation of surrounding code.
…osshair, fix error
|
@Rainyan @nullsystem as a compromise I added the hip fire crosshair to the crosshair settings page and disabled it by default, that way it should be obvious that the feature exists to people who haven't heard about the feature once they check that page, and people who don't like it don't see it by default. I think this should give us a good enough environment for testing the feature out |
Rainyan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Oh whoops, apologies for the triple review request 😅 |
sunzenshen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked out the different dynamic crosshair types and lgtm.
|
@nullsystem Am I good to merge, can update crosshair version closer to when we know next version number? |
|
It would also be interesting to change the bot crosshairs to be a dynamic one, to advertise the feature to new players, but that's possibly a subjective opinion. (not parity) |
Bikeshedding, but IMO bots should ideally display the crosshair that the player has chosen as their preference, rather than being replicated. |
Since we have the bot profiles PR branch open, we could add some personalized crosshairs to all the bots. I don't know if the original devs would be interested in hopping on and making a crosshair for themselves though |
72b2aa3
Description
Changes in neoAssets
Adds an option for a dynamic crosshair. Depending on the type of dynamic crosshair chosen, different parts of the crosshair will grow and shrink with the player accuracy.
Adds an option to show accuracy when using scoped weapons. The same offset used in the normal crosshair is used to draw two more scopes inside the scope view.
Adds an option for a hip fire crosshair for testing
Linked Issues