-
Notifications
You must be signed in to change notification settings - Fork 21
Update to submodules for NDSL, pyPFV3, and pySHiELD
#156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to submodules for NDSL, pyPFV3, and pySHiELD
#156
Conversation
|
Looks like there's some work involved here to make the type system happy (again). The new NDSL version has way more (and partly stricter) types. |
|
I have some proposed type tweaks that may help with the linting errors: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, obviously pending lint passing.
|
Quick update: both pre-requisits have been merged. @jjuyeonkim feel free to take over this PR if this is blocking you and you want to have it merged as soon as possible. If not, I'll do the update tomorrow. |
|
Tomorrow is fine. Thanks for doing this! |
This PR updates NDSL to a few commits after version 2025.10.00 and syncs pyFV3 and pySHiELD to their current `develop` branch. The release version of NDSL was raisning type issues that were only caught in pace. We are working on streamlining this experience for future releases of NDSL.
9c2e088 to
8100ad7
Compare
NDSL, pyPFV3, and pySHiELD
|
Looks like this is ready to merge now with the latest fixes 🚀 |
Description
This PR updates NDSL to a few commits after version 2025.10.00 and syncs pyFV3 and pySHiELD to their current
developbranch. The release version of NDSL was raisning type issues that were only caught in pace. We are working on streamlining this experience for future releases of NDSL.How Has This Been Tested?
All good as long as CI is still green.
Checklist:
New NDSL version might trigger some deprecation warnings