Skip to content

Conversation

@romanc
Copy link
Collaborator

@romanc romanc commented Oct 28, 2025

Description

This PR updates NDSL to a few commits after version 2025.10.00 and syncs pyFV3 and pySHiELD to their current develop branch. The release version of NDSL was raisning type issues that were only caught in pace. We are working on streamlining this experience for future releases of NDSL.

How Has This Been Tested?

All good as long as CI is still green.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas: N/A
  • I have made corresponding changes to the documentation: N/A
  • My changes generate no new warnings
    New NDSL version might trigger some deprecation warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included: N/A

@romanc
Copy link
Collaborator Author

romanc commented Oct 28, 2025

Looks like there's some work involved here to make the type system happy (again). The new NDSL version has way more (and partly stricter) types.

@jjuyeonkim
Copy link
Collaborator

jjuyeonkim commented Oct 28, 2025

Copy link
Contributor

@fmalatino fmalatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, obviously pending lint passing.

@romanc
Copy link
Collaborator Author

romanc commented Oct 29, 2025

Quick update: both pre-requisits have been merged. @jjuyeonkim feel free to take over this PR if this is blocking you and you want to have it merged as soon as possible. If not, I'll do the update tomorrow.

@jjuyeonkim
Copy link
Collaborator

Tomorrow is fine. Thanks for doing this!

This PR updates NDSL to a few commits after version 2025.10.00 and
syncs pyFV3 and pySHiELD to their current `develop` branch. The release
version of NDSL was raisning type issues that were only caught in pace.
We are working on streamlining this experience for future releases of
NDSL.
@romanc romanc force-pushed the romanc/update-NDSL-2025.10.00 branch from 9c2e088 to 8100ad7 Compare October 30, 2025 07:37
@romanc romanc changed the title Update to NDSL 2025.10.00 (sync pyFV3, pySHiELD to develop) Update to submodules for NDSL, pyPFV3, and pySHiELD Oct 30, 2025
@romanc
Copy link
Collaborator Author

romanc commented Oct 30, 2025

Looks like this is ready to merge now with the latest fixes 🚀

@fmalatino fmalatino added this pull request to the merge queue Oct 30, 2025
Merged via the queue into NOAA-GFDL:develop with commit 6866e55 Oct 30, 2025
2 checks passed
@romanc romanc deleted the romanc/update-NDSL-2025.10.00 branch October 30, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants