Skip to content

Conversation

@romanc
Copy link
Collaborator

@romanc romanc commented Oct 30, 2025

Description

This is a follow-up from updating NDSL in PR #156. We get rid of deprecation warnings to avoid future problems when the API changes.

Quick note on the extra_dim_lengths: We can remove empty dictionaries {} because that's now the default. Previously that default wasn't re-entrant so many places specified the option explicitly. Now there's no need anymore for this.

How Has This Been Tested?

This is a pure refactor. All good as long as current tests don't complain.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation: N/A
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included: N/A

Change `extra_dim_lengths` -> `data_dimensions` when creating a
`SubtileGridSizer`. We can remove empty dictionaries `{}` because that's
now the default. Previously that default wasn't re-entrant so many
places specified the option explicitly. Now there's no need anymore for
this.
@romanc
Copy link
Collaborator Author

romanc commented Oct 30, 2025

/cc @twicki & @FlorianDeconinck FYI

@romanc romanc force-pushed the romanc/avoid-deprecation-warnings branch from 5ea9cee to f752b50 Compare October 30, 2025 13:33
@jjuyeonkim jjuyeonkim added this pull request to the merge queue Oct 30, 2025
Merged via the queue into NOAA-GFDL:develop with commit 8842f2f Oct 30, 2025
2 checks passed
@romanc romanc deleted the romanc/avoid-deprecation-warnings branch October 30, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants