ci: stricter type checks with mypy
          #97
        
          
      
                
     Open
            
            
          
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Description
This PR suggests better defaults for the
mypyconfiguration. The new rules apply don't apply withinpyfv3.stencils. That would have been too much effort to start with. Types aren't less safe than before because before the exceptions were just made for the whole repo (now it's contained topyfv3.stencilsand select files that weren't typed before).In addition, the PR includes
flake8-bugbearDict[...]-> dict[...])Note that even this configuration doesn't catch, what is about to be fixed in #96 (for NOAA-GFDL/pace#156).
/cc @twicki @FlorianDeconinck
How Has This Been Tested?
Self testing with new checks by
mypyandflake8-bugbear. All good as long as CI (in particular the linting job) is still green.Checklist: