[TASK] Add Positionable interface and implementing trait
#1221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeQZ
added this to the 9.0.0: Drop support for PHP < 7.2 and clean up things milestone
JakeQZ
force-pushed
the
task/positionable
branch
from
093e1e2 to
5eeead2
Compare
JakeQZ
force-pushed
the
task/positionable
branch
from
5eeead2 to
0553f9d
Compare
|
Deprecation can be brought forward if it's possible to (easily) merge these changes to the 8.x branch. Once the follow-up PR (to use the interfaces) is committed, we'll be able to see how possible that is. |
JakeQZ
force-pushed
the
task/positionable
branch
from
0553f9d to
579ee0f
Compare
oliverklee
changed the title
Positionalable interface and implementing traitPositionable interface and implementing trait
JakeQZ
force-pushed
the
task/positionable
branch
from
579ee0f to
f54dadb
Compare
|
Changelog entries will be added with the follow-up PR to implement and use the interface and trait. I've fixed the typo in the commit message title. |
oliverklee
requested changes
Mar 29, 2025
This is for CSS items which have a position in the document. New methods are added: - `getLineNumber` to replace `getLineNo`; - `getColumnNumber` to replace `getColNo`. These return a nullable `int`, instead of using zero to indicate absence. The old methods are now deprecated, but defined in the interface and implemented in the trait. Note that this change only adds the interface and trait. It does not modify any classes to actually implement or use these. Part of #1207.
JakeQZ
force-pushed
the
task/positionable
branch
from
f54dadb to
d77aba0
Compare
oliverklee
approved these changes
Mar 30, 2025
JakeQZ
added a commit
that referenced
this pull request
Apr 6, 2025
This is for CSS items which have a position in the document. New methods are added: - `getLineNumber` to replace `getLineNo`; - `getColumnNumber` to replace `getColNo`. These return a nullable `int`, instead of using zero to indicate absence. The old methods are now deprecated, but defined in the interface and implemented in the trait. Note that this change only adds the interface and trait. It does not modify any classes to actually implement or use these. Part of #1207.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for CSS items which have a position in the document.
New methods are added:
getLineNumberto replacegetLineNo;getColumnNumberto replacegetColNo.These return a nullable
int, instead of using zero to indicate absence.The old methods are now deprecated, but defined in the interface and implemented in the trait.
Note that this change only adds the interface and trait. It does not modify any classes to actually implement or use these.
Part of #1207.