Skip to content

Rename getLineNo() to getLineNumber() #974

Closed
@oliverklee

Description

@oliverklee

Also getColNo() to getColumnNumber().

  • add getLineNumber() (returning nullable positive int) and change getLineNo() to call it in V8.x
  • deprecate getLineNo() in V8.x
  • add unit tests for all methods in RuleSet (and fix issues found)
    • addRule()
      • without sibling argument
      • with sibling argument
    • removeRule()
    • removeMatchingRules()
    • removeAllRules()
    • setRules()
    • getRules()
      • without search pattern argument
      • with search pattern argument
    • getRulesAssoc()
      • without search pattern argument
      • with search pattern argument
  • ensure all Rules in RuleSet always have non-null line and column numbers
  • update codebase to use getLineNumber()
    • in direct unit tests
    • in functional tests
    • in internal methods
  • remove getLineNo()

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions