Skip to content

[TASK] Implement Positionable #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 1, 2025
Merged

[TASK] Implement Positionable #1225

merged 2 commits into from
Apr 1, 2025

Conversation

JakeQZ
Copy link
Contributor

@JakeQZ JakeQZ commented Mar 30, 2025 •
edited
Loading

Closes #1207.

@JakeQZ JakeQZ added the cleanup label Mar 30, 2025
@JakeQZ JakeQZ self-assigned this Mar 30, 2025
@JakeQZ JakeQZ marked this pull request as draft March 30, 2025 00:31
@coveralls
Copy link

coveralls commented Mar 30, 2025 •
edited
Loading

Coverage Status

coverage: 53.315% (+0.2%) from 53.134%
when pulling bc7599b on task/implement-positionable
into 36ed5cd on main.

@JakeQZ JakeQZ force-pushed the task/implement-positionable branch from 462a05b to 58e125a Compare March 30, 2025 01:22
@JakeQZ
Copy link
Contributor Author

JakeQZ commented Mar 30, 2025

If #1221 is accepted as it is now, this PR will be ready for review. It includes the changes from #1221; there should not be a merge conflict, since they are the same. I've marked it as 'blocked' (but not 'draft') for the time being...

@JakeQZ JakeQZ added the blocked Needs another issue to be resolved first label Mar 30, 2025
@JakeQZ JakeQZ requested a review from oliverklee March 30, 2025 01:32
@JakeQZ JakeQZ marked this pull request as ready for review March 30, 2025 01:32
@JakeQZ JakeQZ force-pushed the task/implement-positionable branch from 58e125a to c3f49e2 Compare March 30, 2025 01:35
@JakeQZ JakeQZ removed the blocked Needs another issue to be resolved first label Mar 30, 2025
@JakeQZ JakeQZ force-pushed the task/implement-positionable branch from c3f49e2 to fb48ed3 Compare March 30, 2025 12:14
@JakeQZ
Copy link
Contributor Author

JakeQZ commented Mar 30, 2025

Rebased so the diff doesn't now also include #1221.

@JakeQZ
Copy link
Contributor Author

JakeQZ commented Mar 30, 2025

Coveralls server is broken at the moment, returning HTTP 405 error. We changed this to not fail the build if coverage went down. Can we also change it to not fail the build if it fails to run - since it is information only?

@JakeQZ
Copy link
Contributor Author

JakeQZ commented Mar 30, 2025

Coveralls server is broken at the moment, returning HTTP 405 error.

It says it is down for planned maintenance.

@JakeQZ
Copy link
Contributor Author

JakeQZ commented Mar 30, 2025

Coveralls server is broken at the moment, returning HTTP 405 error.

It says it is down for planned maintenance.

It's now back online, and all checks have passed.

@JakeQZ JakeQZ force-pushed the task/implement-positionable branch 2 times, most recently from 61892a6 to 8b8a38e Compare March 30, 2025 22:46
oliverklee
oliverklee requested changes Mar 31, 2025
View reviewed changes
Copy link
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

We also need to update the class diagram, though.

@JakeQZ JakeQZ force-pushed the task/implement-positionable branch 2 times, most recently from 9d64ff0 to 470aeb3 Compare March 31, 2025 14:42
@JakeQZ JakeQZ force-pushed the task/implement-positionable branch from 470aeb3 to bc7599b Compare March 31, 2025 14:45
@JakeQZ JakeQZ requested a review from oliverklee March 31, 2025 14:47
@oliverklee oliverklee merged commit 9b52615 into main Apr 1, 2025
21 checks passed
@oliverklee oliverklee deleted the task/implement-positionable branch April 1, 2025 08:32
JakeQZ added a commit that referenced this pull request Apr 6, 2025
@JakeQZ
[TASK] Add and implement Positionable interface
ddd999e 
This the backport of #1221 and #1225.
JakeQZ added a commit that referenced this pull request Apr 6, 2025
@JakeQZ
Apply #1225.
f82fd72
@JakeQZ JakeQZ mentioned this pull request Apr 6, 2025
Merged
JakeQZ added a commit that referenced this pull request Apr 6, 2025
@JakeQZ
Apply #1225.
e15ad16
JakeQZ added a commit that referenced this pull request Apr 6, 2025
@JakeQZ
Apply #1225.
70ae485
oliverklee pushed a commit that referenced this pull request Apr 7, 2025
@JakeQZ
[TASK] Add and implement Positionable interface (#1232)
e100b80 
This the backport of #1221 and #1225.
@JakeQZ JakeQZ mentioned this pull request Apr 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverklee oliverklee oliverklee approved these changes

Assignees

@JakeQZ JakeQZ

Labels
cleanup
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.

Add interface and trait for classes with a lineNumber
3 participants
@JakeQZ @coveralls @oliverklee