Angle refactor + tests! #42
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
the KalmanFilter branch is out of date. Can you change the PR to merge into main? |
…intIndex in Path.java and having Path.incrementCurrentPointIndex make all changes with a Path.isFinished helper to determine if all the path has been traversed
Collaborator
|
Hey there! Could you please separate this PR into multiple? Ideally, it should be broken into one for the bugfix (highest priority) and then split the refactor of the Angle stuff into another PR. The tests are awesome, they've been on my to-do list for a while. tl;dr: Unrelated bugfix/features should be separated please |
Owner
|
I'm going to start including some of this stuff in main incrementally. Pinging @Astr0clad |
Mineinjava
reviewed
Aug 3, 2024
| Pose2d p = points.get(i); | ||
| double distance = Math.sqrt(Math.pow(point.x - point.x, 2) + Math.pow(point.y - point.y, 2)); | ||
| // TODO(Bernie, pre merge): Change to infinity | ||
| double minDistance = 10000, distance; |
Owner
There was a problem hiding this comment.
It doesn't matter because the min distance has to be lower than the first one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog