Assigns a default endpoing to westus if no endpoint is supplied #1574
Conversation
|
Fix for issue #1387 |
|
We had a test for this exact behavior, and that test is now failing: |
cleemullins
left a comment
cleemullins
left a comment
There was a problem hiding this comment.
Code change - need a test.
Please update the existing test for the new condition.
| if (string.IsNullOrWhiteSpace(endpoint)) | ||
| { | ||
| throw new ArgumentException($"\"{endpoint}\" is not a valid LUIS endpoint."); | ||
| endpoint = "https://westus.api.cognitive.microsoft.com"; |
There was a problem hiding this comment.
To achieve parity with JS I think the endpoint validation should be removed from this file, and the endpoint should be assigned if null or empty in the LuisRecognizer construction. Let me know your thoughts.
Thanks
There was a problem hiding this comment.
Yeah, agree with Emilio - primarily because it's a get/set on the endpoint, and someone could sneak around the validation for fun, after initial creation..
May want to take a look at the other properties as well..
In reply to: 270952889 [](ancestors = 270952889)
munozemilio
left a comment
munozemilio
left a comment
There was a problem hiding this comment.
Comments in line.
Thanks
|
Completed via PR #1626. |
Updates the luisApplication.cs file to set a default endpoint of 'https://westus.api.cognitive.microsoft.com' when no endpoint is supplied.