This repository was archived by the owner on Jan 5, 2026. It is now read-only.
Update telemetry logger to include attachments #3737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabog
approved these changes
Apr 14, 2020
Contributor
gabog
left a comment
gabog
left a comment
There was a problem hiding this comment.
If time permits, it would be good to start shrinking technical debt and add unit tests (we don't seem to have any for TelemetryLoggerMiddleware) but you can skip that for now if you don't have time.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1574 in JS repo (https://github.com/microsoft/botbuilder-js/issues/1574)
Telemetry logger will now include the collection of any attachments sent with the activity, if the LogPersonalInformation flag is set to true.