Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Assigns a default endpoing to westus if no endpoint is supplied #1574

Closed
stevkan wants to merge 1 commit into from
Closed

Assigns a default endpoing to westus if no endpoint is supplied #1574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libraries/Microsoft.Bot.Builder.AI.LUIS/LuisApplication.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ private LuisApplication(ValueTuple<string, string, string> props)

if (string.IsNullOrWhiteSpace(endpoint))
{
throw new ArgumentException($"\"{endpoint}\" is not a valid LUIS endpoint.");
endpoint = "https://westus.api.cognitive.microsoft.com";
Copy link
Contributor

@munozemilio munozemilio Apr 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To achieve parity with JS I think the endpoint validation should be removed from this file, and the endpoint should be assigned if null or empty in the LuisRecognizer construction. Let me know your thoughts.

Thanks

Copy link
Contributor

@daveta daveta Apr 1, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, agree with Emilio - primarily because it's a get/set on the endpoint, and someone could sneak around the validation for fun, after initial creation..
May want to take a look at the other properties as well..

In reply to: 270952889 [](ancestors = 270952889)

}

if (!Uri.IsWellFormedUriString(endpoint, UriKind.Absolute))
Expand Down