feat: new-srp-sentry #16401
Closed
feat: new-srp-sentry #16401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amask-mobile into feat/new-srp-backup
…amask-mobile into feat/new-srp-backup
…ask/metamask-mobile into feat/new-create-import-srp
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Update New SRP onboarding flow as per figma design https://www.figma.com/design/pViOUcmjwhEzFsdrwknpNc/Onboarding-redesign?node-id=434-55200&t=wmEoQSF9g9lFtkwp-0 This PR is part 2 of 7 for the new SRP ui update This PR covers - new ui for welcome page <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Fixes: ## **Manual testing steps** 1. After opening app, agree to terms 2. Come to the Let's get started page ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/2e37d1a2-3587-42d5-b90a-9965b5168ed2 ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Chaitanya Potti <chaitanya.potti@gmail.com> Co-authored-by: smgv <gpatra1996@gmail.com> Co-authored-by: hieu-w <maestrokoder@gmail.com> Co-authored-by: hieu-w <hieu@tor.us>
Contributor
|
chaitanyapotti
added
the
No QA Needed
|
Contributor
Author
|
close in favor of #16232 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds Sentry performance monitoring to track user onboarding flows end-to-end. We're instrumenting all onboarding paths (social login, SRP creation, import) to gain visibility into performance bottlenecks and error rates.
The implementation uses buffered tracing to handle cases where metrics consent hasn't been given yet - traces are queued and sent once the user opts in to metrics collection.
New traces being added (click to expand)
User Journey Traces:
Onboarding - Overall Journey- Parent trace for entire onboarding flowOnboarding - New SRP Create WalletOnboarding - Existing SRP ImportOperation Traces:
Onboarding - Password Setup AttemptOnboarding - Password Login AttemptOnboarding - Reset PasswordOnboarding - Create Key and Backup SRPOnboarding - Add SRPOnboarding - Fetch SRPsError Traces:
Onboarding - Social Login ErrorOnboarding - Password Setup ErrorOnboarding - Password Login ErrorOnboarding - Reset Password ErrorOnboarding - Create Key and Backup SRP ErrorOnboarding - Add SRP ErrorOnboarding - Fetch SRPs ErrorPort from #16232
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist