Skip to content

feat: New welcome screen #15666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tommasini merged 20 commits into from
May 30, 2025
Merged

feat: New welcome screen #15666

tommasini merged 20 commits into from
May 30, 2025

Conversation

@ieow
Copy link
Contributor

@ieow ieow commented May 26, 2025 •
edited by chaitanyapotti
Loading

Description

Update New SRP onboarding flow as per figma design
https://www.figma.com/design/pViOUcmjwhEzFsdrwknpNc/Onboarding-redesign?node-id=434-55200&t=wmEoQSF9g9lFtkwp-0

This PR is part 2 of 7 for the new SRP ui update

This PR covers

  • new ui for welcome page

Related issues

Fixes:

Manual testing steps

  1. After opening app, agree to terms
  2. Come to the Let's get started page

Screenshots/Recordings

Before

After

Screen.Recording.2025-05-21.at.8.49.18.AM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@smgv smgv changed the title feat: new welcome screen - let get started feat: 1.3 new welcome screen - let get started May 27, 2025
@chaitanyapotti chaitanyapotti changed the title feat: 1.3 new welcome screen - let get started feat: 1.2 new welcome screen - let get started May 27, 2025
chaitanyapotti
chaitanyapotti reviewed May 27, 2025
View reviewed changes
chaitanyapotti
chaitanyapotti reviewed May 27, 2025
View reviewed changes
chaitanyapotti
chaitanyapotti reviewed May 27, 2025
View reviewed changes
chaitanyapotti
chaitanyapotti reviewed May 27, 2025
View reviewed changes
@chaitanyapotti chaitanyapotti changed the title feat: 1.2 new welcome screen - let get started feat: New welcome screen May 27, 2025
@github-project-automation github-project-automation bot moved this to Needs dev review in PR review queue May 27, 2025
@chaitanyapotti chaitanyapotti marked this pull request as ready for review May 27, 2025 08:57
@chaitanyapotti chaitanyapotti requested a review from a team as a code owner May 27, 2025 08:57
@chaitanyapotti chaitanyapotti added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label May 27, 2025
@chaitanyapotti chaitanyapotti added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels May 27, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 27, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e42821b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/02c78ee2-a1fa-4a45-bc0e-e64d3360f2b8

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions
Copy link
Contributor

github-actions bot commented May 29, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: baf9139
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8f23463f-af4f-4cf6-b4c6-92283db07726

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@tommasini
Copy link
Contributor

tommasini commented May 29, 2025

This code lgtm, the only doubt I have is at this comment

tommasini
tommasini reviewed May 29, 2025
View reviewed changes
e2e/specs/identity/account-syncing/sync-after-onboarding.spec.js Outdated

it('retrieves all previously synced accounts', async () => {
// TODO: enable this test when MetaMetricsOptIn is back
it.skip('retrieves all previously synced accounts', async () => {
Copy link
Contributor

@tommasini tommasini May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will enable this at this PR: #15669

Copy link
Contributor Author

@ieow ieow May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We revert the optin navigation and re-enable the test.
We will create another pr to address the new ui flow with the delayed optin

@github-actions
Copy link
Contributor

github-actions bot commented May 30, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 3622495
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9154c470-c37a-4c8d-924f-f7a5595e6721

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@github-project-automation github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue May 30, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 30, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
91.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link
Contributor

github-actions bot commented May 30, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9be7048
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2a57fbac-0052-47c1-a188-002ba3ccee3f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@tommasini tommasini merged commit 4eeb8bc into feat/srp-onboarding-carousel-tnc May 30, 2025
47 of 50 checks passed
@tommasini tommasini deleted the feat/new-srp-welcome branch May 30, 2025 17:03
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chaitanyapotti chaitanyapotti chaitanyapotti left review comments

@tommasini tommasini tommasini approved these changes

Assignees

@chaitanyapotti chaitanyapotti

@ieow ieow

Labels

area-onboarding No QA Needed Apply this label when your PR does not need any QA effort. team-onboarding Onboarding team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ieow @tommasini @chaitanyapotti @metamaskbot @hieu-w @smgv