Skip to content

feat: 2.7 Chore/sentry onboarding cp-7.52.0 #16232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chaitanyapotti merged 190 commits into from
Jul 21, 2025
Merged

feat: 2.7 Chore/sentry onboarding cp-7.52.0 #16232

chaitanyapotti merged 190 commits into from
Jul 21, 2025

Conversation

@huggingbot
Copy link
Member

@huggingbot huggingbot commented Jun 10, 2025 •
edited
Loading

Description

This PR adds Sentry performance monitoring to track user onboarding flows end-to-end. We're instrumenting all onboarding paths (social login, SRP creation, import) to gain visibility into performance bottlenecks and error rates.

The implementation uses buffered tracing to handle cases where metrics consent hasn't been given yet - traces are queued and sent once the user opts in to metrics collection.

New traces being added (click to expand)

User Journey Traces:

  • Onboarding - Overall Journey - Parent trace for entire onboarding flow
  • Onboarding - New SRP Create Wallet
  • Onboarding - New Social Create Wallet
  • Onboarding - New Social Account Exists
  • Onboarding - Existing SRP Import
  • Onboarding - Existing Social Login
  • Onboarding - Existing Social Account Not Found

Operation Traces:

  • Onboarding - Social Login Attempt
  • Onboarding - Password Setup Attempt
  • Onboarding - Password Login Attempt
  • Onboarding - Reset Password
  • Onboarding - Create Key and Backup SRP
  • Onboarding - Add SRP
  • Onboarding - Fetch SRPs
  • Onboarding - OAuth Provider Login
  • Onboarding - OAuth BYOA Server Get Auth Tokens
  • Onboarding - OAuth Seedless Authenticate

Error Traces:

  • Onboarding - Social Login Error
  • Onboarding - Password Setup Error
  • Onboarding - Password Login Error
  • Onboarding - Reset Password Error
  • Onboarding - Create Key and Backup SRP Error
  • Onboarding - Add SRP Error
  • Onboarding - Fetch SRPs Error
  • Onboarding - OAuth Provider Login Error
  • Onboarding - OAuth BYOA Server Get Auth Tokens Error
  • Onboarding - OAuth Seedless Authenticate Error

Related issues

Fixes:

Manual testing steps

  1. Kill the app and clear data to start fresh
  2. Launch app and go through onboarding as a new user with social login
  3. Verify traces appear in Sentry under "Onboarding - Overall Journey"
  4. Test other flows:
    • New user creating wallet with password
    • Existing user importing SRP
    • Social login with existing account
  5. Check that error traces are captured when operations fail (e.g., network errors)

Screenshots/Recordings

Overall onboarding journey involving a new social login and password setup
Screenshot 2025-06-13 at 9 22 51 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 10, 2025 •
edited
Loading

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@huggingbot huggingbot added the team-onboarding Onboarding team label Jun 11, 2025
@huggingbot
Copy link
Member Author

huggingbot commented Jun 13, 2025

I have read the CLA Document and I hereby sign the CLA

@metamaskbot metamaskbot added INVALID-PR-TEMPLATE PR's body doesn't match template and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Jun 13, 2025
@ieow ieow mentioned this pull request Jun 18, 2025
Closed
7 tasks
ieow and others added 19 commits June 26, 2025 11:26
@ieow
feat: clean up oauth service
6613043 
remove unwanted lint changes
@ieow
fix: remove build flag
d1465f8
@ieow
fix: remove unused added assets
e08a4ca
@ieow
fix: oauth config
9554498
@ieow
chore: address comment
6a7aca4
@ieow
fix : check for getBundleId
78bc655
@ieow
fix: default ios google client bundleid
ee72c36
@ieow
fix: remove oauth env from js.env.example
20b3a03
@ieow
feat: implement onboarding sheet and account status screens
a4950c6 
- Added OnboardingSheet component for user onboarding options.
- Integrated AccountStatus component to handle existing account scenarios.
- Updated navigation routes to include new onboarding flows.
- Enhanced ChoosePassword component to support OAuth login success handling.
- Updated localization files to include new strings for onboarding and account status.
- Added tests for new components and updated existing tests for integration.

This commit enhances the user experience during onboarding and account management by providing clear options and feedback for existing users.
@ieow
fix: add OTHER_METHODS_BUTTON selector to LoginView
f929f36
@ieow
feat: remove seedless onboarding Build Flag from Login, Onboarding, a…
0eecdd9 
…nd Authentication components
@ieow
fix: update snapshot
375660c
@huggingbot
test: enhance Login component tests with authentication scenarios
ebbeaab
@huggingbot
fix: Failing tests in Onboarding view after merge
d365d5d
@huggingbot
test: enhance App component tests with onboarding navigation scenarios
a4649ef
@huggingbot
test: add tests for SOLANA_DISCOVERY_PENDING handling in wallet creat…
db0af35 
…ion and restoration
@huggingbot
test: add rehydrateSeedPhrase tests for seed phrase handling in Authe…
368ff2c 
…ntication module
@ieow
fix: seedless onboarding runtime env
6cea7a3
@ieow @smgv
feat: multi-srp
d08fbac 
Co-authored-by: Ganesh Suresh Patra <ganesh.patra@consensys.net>
@ieow ieow force-pushed the feat/seedless-multi-srp-sync branch from bb73b24 to d08fbac Compare June 30, 2025 06:53
@huggingbot huggingbot force-pushed the chore/sentry-onboarding branch from dd9ad13 to 89af4c6 Compare June 30, 2025 07:13
@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4139148
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7787f868-7c6e-457a-9781-02bfce8fc805

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@chaitanyapotti chaitanyapotti added this pull request to the merge queue Jul 21, 2025
@chaitanyapotti chaitanyapotti removed this pull request from the merge queue due to a manual request Jul 21, 2025
@chaitanyapotti chaitanyapotti changed the title feat: 2.7 Chore/sentry onboarding feat: 2.7 Chore/sentry onboarding cp-7.52.0 Jul 21, 2025
@chaitanyapotti chaitanyapotti added this pull request to the merge queue Jul 21, 2025
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jul 21, 2025
Merged via the queue into main with commit 9d8183d Jul 21, 2025
70 of 74 checks passed
@chaitanyapotti chaitanyapotti deleted the chore/sentry-onboarding branch July 21, 2025 12:23
@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2025
@metamaskbot metamaskbot added the release-7.53.0 Issue or pull request that will be included in release 7.53.0 label Jul 21, 2025
@metamaskbot metamaskbot added release-7.52.0 Issue or pull request that will be included in release 7.52.0 and removed release-7.53.0 Issue or pull request that will be included in release 7.53.0 labels Sep 3, 2025
@metamaskbot
Copy link
Collaborator

metamaskbot commented Sep 3, 2025

Missing release label release-7.52.0 on PR. Adding release label release-7.52.0 on PR and removing other release labels(release-7.53.0), as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 8, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

9 similar comments
@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 8, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 8, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 14, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 20, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 20, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 20, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 20, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 20, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 20, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@chaitanyapotti chaitanyapotti chaitanyapotti approved these changes

Assignees

No one assigned

Labels

area-onboarding INVALID-PR-TEMPLATE PR's body doesn't match template No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.52.0 Issue or pull request that will be included in release 7.52.0 team-onboarding Onboarding team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@huggingbot @metamaskbot @chaitanyapotti @codecov-commenter @hieu-w @ieow @smgv