Skip to content

fix: eth-json-rpc-middleware@9 -> @metamask/eth-json-rpc-middleware@11 #12047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2024
Merged

fix: eth-json-rpc-middleware@9 -> @metamask/eth-json-rpc-middleware@11 #12047

merged 1 commit into from
Oct 29, 2024

Conversation

@legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 28, 2024 •
edited
Loading

Description

Migrate from legacy eth-json-rpc-middleware to @metamask/eth-json-rpc-middleware, holding at v11.

Removes usage of eth-block-tracker v5.

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link

socket-security bot commented Oct 28, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/eth-block-tracker@7.1.0 None 0 58.1 kB gudahtt
npm/safe-stable-stringify@2.5.0 None 0 30.7 kB bridgear

🚮 Removed packages: npm/btoa@1.2.1, npm/eth-json-rpc-middleware@9.0.1, npm/json-stable-stringify@1.0.1, npm/jsonify@0.0.0, npm/safe-stable-stringify@2.4.3

View full report↗︎

@legobeat legobeat added dependencies Pull requests that update a dependency file team-application-security Application security team Run Smoke E2E labels Oct 28, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7b2b592
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b43fb22c-575a-42ee-b0d5-be7e52b23471

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat mentioned this pull request Oct 28, 2024
Merged
7 tasks
@legobeat legobeat marked this pull request as ready for review October 28, 2024 20:59
@legobeat legobeat requested review from a team as code owners October 28, 2024 20:59
@legobeat legobeat requested a review from a team October 28, 2024 20:59
@legobeat legobeat requested a review from a team as a code owner October 28, 2024 20:59
@legobeat legobeat force-pushed the deps-eth-json-rpc-filters-8 branch from 887febd to 1a73659 Compare October 28, 2024 21:01
@legobeat legobeat force-pushed the deps-eth-json-rpc-middleware-11 branch from 7b2b592 to 6c0690a Compare October 28, 2024 21:03
@legobeat legobeat force-pushed the deps-eth-json-rpc-filters-8 branch 2 times, most recently from 5de4d65 to 91fbb80 Compare October 29, 2024 04:04
@legobeat legobeat force-pushed the deps-eth-json-rpc-middleware-11 branch from 6c0690a to b6d0556 Compare October 29, 2024 07:02
@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b6d0556
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/aa43225d-b700-441a-a8ad-2fb5104d0b29

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat force-pushed the deps-eth-json-rpc-filters-8 branch from 91fbb80 to 965efb0 Compare October 29, 2024 09:49
@legobeat legobeat force-pushed the deps-eth-json-rpc-middleware-11 branch from b6d0556 to ff38c03 Compare October 29, 2024 12:42
github-merge-queue bot pushed a commit that referenced this pull request Oct 29, 2024
@legobeat
chore: eth-json-rpc-filters@^6.0.1 -> @metamask/eth-json-rpc-filters@…
c773d7a 
…^8.0.0 (#12024)

## **Description**

Replace deprecated `eth-json-rpc-filters` with
`@metamask/eth-json-rpc-filters`.

## **Related issues**

- Part of: #12047
- Broken out from: #9274, #11952
- Follow-up to: #11980


## **Manual testing steps**


## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Base automatically changed from deps-eth-json-rpc-filters-8 to main October 29, 2024 12:49
@legobeat legobeat force-pushed the deps-eth-json-rpc-middleware-11 branch from ff38c03 to 47d6dbd Compare October 29, 2024 12:53
@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 47d6dbd
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/04f18d70-6637-4426-879b-de8792b47677

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat mentioned this pull request Oct 29, 2024
Merged
23 tasks
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@legobeat legobeat changed the title deps: eth-json-rpc-middleware@9 -> @metamask/eth-json-rpc-middleware@11 fix: eth-json-rpc-middleware@9 -> @metamask/eth-json-rpc-middleware@11 Oct 29, 2024
@legobeat legobeat added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit 8ddfa32 Oct 29, 2024
46 of 47 checks passed
@legobeat legobeat deleted the deps-eth-json-rpc-middleware-11 branch October 29, 2024 14:17
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@FrederikBolding FrederikBolding FrederikBolding approved these changes

@tommasini tommasini tommasini approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file release-7.35.0 Issue or pull request that will be included in release 7.35.0 team-application-security Application security team team-lavamoat

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@legobeat @FrederikBolding @tommasini @metamaskbot