Skip to content

fix: eth-json-rpc-filters@^5.1.0->^6.0.1 #11980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2024
Merged

fix: eth-json-rpc-filters@^5.1.0->^6.0.1 #11980

merged 1 commit into from
Oct 25, 2024

Conversation

@legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 23, 2024 •
edited
Loading

Description

  • Bump legacy eth-json-rpc-filters from v5 to v6

Related issues

Follow-up to: #11975

Blocking

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat force-pushed the deps-eth-json-rpc-filters-6 branch from 0703bc1 to 1768fb3 Compare October 23, 2024 14:34
@legobeat legobeat added dependencies Pull requests that update a dependency file team-application-security Application security team Run Smoke E2E and removed team-lavamoat labels Oct 23, 2024
@socket-security
Copy link

socket-security bot commented Oct 23, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/eth-json-rpc-filters@6.0.1 None +1 51.7 kB gudahtt

🚮 Removed packages: npm/eth-json-rpc-filters@5.1.0

View full report↗︎

@legobeat legobeat changed the title deps: eth-json-rpc-filters@^5.1.0->^6.0.1 chore: eth-json-rpc-filters@^5.1.0->^6.0.1 Oct 23, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 1768fb3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/aabfa83f-1b64-4bf8-a5c7-6edf2f74f8c6

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat changed the title chore: eth-json-rpc-filters@^5.1.0->^6.0.1 fix: eth-json-rpc-filters@^5.1.0->^6.0.1 Oct 23, 2024
@legobeat legobeat mentioned this pull request Oct 23, 2024
Merged
23 tasks
@legobeat legobeat force-pushed the deps-eth-json-rpc-filters-6 branch from 1768fb3 to e878591 Compare October 23, 2024 14:59
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e878591
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/58d28665-e57e-494f-9dc0-5f294b0cb15e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat marked this pull request as ready for review October 23, 2024 15:00
@legobeat legobeat requested a review from a team as a code owner October 23, 2024 15:00
@legobeat legobeat requested a review from a team October 23, 2024 15:00
@legobeat legobeat requested a review from a team as a code owner October 23, 2024 15:00
@legobeat legobeat force-pushed the deps-eth-json-rpc-filters-6 branch from e878591 to c832851 Compare October 23, 2024 15:26
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c832851
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fb9a26c0-c66e-4051-b47e-3cd8455311cf

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat force-pushed the deps-eth-json-rpc-filters-6 branch from c832851 to a2ad3d7 Compare October 23, 2024 15:42
@legobeat legobeat requested a review from a team October 23, 2024 15:59
@legobeat legobeat force-pushed the deps-eth-json-rpc-filters-6 branch 2 times, most recently from a1b2617 to 0c59d35 Compare October 24, 2024 00:40
@legobeat legobeat force-pushed the deps-eth-json-rpc-filters-6 branch from 0c59d35 to 92f4d6b Compare October 24, 2024 15:04
@legobeat legobeat enabled auto-merge October 24, 2024 15:05
@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 92f4d6b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2d40973d-de14-43a6-b3b5-4d0b19d3a74a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat mentioned this pull request Oct 24, 2024
Merged
8 tasks
@legobeat legobeat force-pushed the deps-eth-json-rpc-filters-6 branch from 92f4d6b to be63d0a Compare October 24, 2024 17:11
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@cortisiko cortisiko added the No QA Needed Apply this label when your PR does not need any QA effort. label Oct 25, 2024
@legobeat legobeat added this pull request to the merge queue Oct 25, 2024
Merged via the queue into main with commit 18a4e45 Oct 25, 2024
39 of 40 checks passed
@legobeat legobeat deleted the deps-eth-json-rpc-filters-6 branch October 25, 2024 01:38
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cortisiko cortisiko cortisiko approved these changes

@mikesposito mikesposito mikesposito approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file No QA Needed Apply this label when your PR does not need any QA effort. release-7.35.0 Issue or pull request that will be included in release 7.35.0 team-application-security Application security team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@legobeat @cortisiko @mikesposito @metamaskbot