fix(#23072): display ENS in confirmation screen

[timi-codes]

Description

This PR displays ENS in confirmation screen when recipient is added as ENS instead of an address

Related issues

Fixes: #23072

Manual testing steps

1. Select Mainnet
2. Click Send
3. Add an ENS recipient ie vitalik.eth
4. Proceed to the next screen
5. See ENS is displayed

Screenshots/Recordings

Before

Before_Screen.Recording.2024-02-21.at.23.51.12.mov

After

After_Screen.Recording.2024-02-21.at.23.47.15.mov

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[timi-codes]

Does anyone have an idea how to fix ci/circleci: prep-deps on circleci

[digiwand]

Fix LGTM!

Also, unsure why prep-deps is failing here. The ci test is failing in another PR as well #22434 (comment)

cc: @HowardBraham

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/eth-json-rpc-infura@9.1.0	Transitive: environment, network	+29	4.89 MB	mcmire
npm/@types/deep-freeze-strict@1.1.2	None	0	2.75 kB	types
npm/@types/ms@0.7.34	None	0	3.2 kB	types
npm/@types/uuid@9.0.8	None	0	6.74 kB	types
npm/@xstate/fsm@2.1.0	environment	0	57.1 kB	xstate-release-bot
npm/apg-js@4.3.0	filesystem	0	1.45 MB	ldthomas
npm/b4a@1.6.6	None	0	38.2 kB	kasperisager
npm/bare-events@2.2.1	None	0	18.9 kB	kasperisager
npm/cron-parser@4.9.0	filesystem	+1	4.38 MB	harrisiirak
npm/get-npm-tarball-url@2.1.0	None	0	8.52 kB	zkochan
npm/jsonschema@1.4.1	None	0	81.8 kB	acubed
npm/pako@1.0.11	None	0	788 kB	vitaly
npm/rfdc@1.3.1	None	0	25.2 kB	matteo.collina
npm/streamx@2.16.1	None	+3	76.3 kB	mafintosh

🚮 Removed packages: npm/@apocentre/alias-sampling@0.5.3, npm/@babel/plugin-proposal-class-properties@7.18.6, npm/@babel/plugin-proposal-nullish-coalescing-operator@7.18.6, npm/@babel/plugin-proposal-optional-chaining@7.21.0, npm/@metamask/json-rpc-engine@7.3.2, npm/@scure/bip32@1.3.1, npm/@scure/bip39@1.2.1, npm/@sinonjs/formatio@5.0.1, npm/@storybook/store@7.4.6, npm/@types/glob@7.2.0, npm/@types/selenium-webdriver@4.1.19, npm/@types/uuid@9.0.2, npm/aproba@2.0.0, npm/are-we-there-yet@3.0.1, npm/babel-plugin-named-exports-order@0.0.2, npm/babel-plugin-react-docgen@4.2.1, npm/c8@7.14.0, npm/character-entities-html4@1.1.3, npm/collapse-white-space@1.0.5, npm/console-control-strings@1.1.0, npm/consolidate@0.16.0, npm/date-now@0.1.4, npm/detect-libc@1.0.3, npm/electron-to-chromium@1.4.613, npm/error-inject@1.0.0, npm/estree-to-babel@3.2.1, npm/exit-on-epipe@1.0.1, npm/fast-redact@3.1.2, npm/gauge@4.0.4, npm/generic-names@2.0.1, npm/gud@1.0.0, npm/has-unicode@2.0.1, npm/hash-sum@2.0.0, npm/ignore-walk@3.0.1, npm/is-alphanumeric@1.0.0, npm/is-whitespace-character@1.0.3, npm/is-word-character@1.0.3, npm/jsonschema@1.2.4, npm/lodash.camelcase@4.3.0, npm/make-fetch-happen@10.2.1, npm/markdown-escapes@1.0.3, npm/mdast-util-compact@2.0.1, npm/mini-create-react-context@0.3.2, npm/minipass-fetch@2.1.2, npm/needle@2.4.0, npm/node-pre-gyp@0.12.0, npm/nopt@6.0.0, npm/npm-bundled@1.1.2, npm/npm-packlist@1.4.8, npm/npmlog@6.0.2, npm/os-tmpdir@1.0.2, npm/osenv@0.1.5, npm/pako@1.0.6, npm/postcss-modules@4.1.3, npm/printj@1.1.2, npm/query-ast@1.0.4, npm/react-resize-detector@7.1.2, npm/read-package-json-fast@3.0.2, npm/sass@1.69.7, npm/sax@1.3.0, npm/scss-parser@1.0.5, npm/simple-update-notifier@2.0.0, npm/state-toggle@1.0.2, npm/string-hash@1.1.3, npm/stringify-entities@3.0.1, npm/trim-trailing-lines@1.1.2, npm/trim@0.0.3, npm/unherit@1.1.2, npm/unique-slug@3.0.0, npm/unist-util-remove-position@2.0.1, npm/vfile-location@3.2.0, npm/wide-align@1.1.5

View full report↗︎

[socket-security]

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert	Package	Note
New author	npm/rfdc@1.3.1	New Author: matteo.collina Previous Author: davidmarkclements
New author	npm/@metamask/eth-json-rpc-infura@9.1.0	New Author: mcmire Previous Author: gudahtt
Unstable ownership	npm/@metamask/eth-json-rpc-infura@9.1.0	Author: mcmire

View full report↗︎

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is unstable ownership?

A new collaborator has begun publishing package versions. Package stability and security risk may be elevated.

Try to reduce the amount of authors you depend on to reduce the risk to malicious actors gaining access to your supply chain. Packages should remove inactive collaborators with publishing rights from packages on npm.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

• @SocketSecurity ignore npm/rfdc@1.3.1
• @SocketSecurity ignore npm/@metamask/eth-json-rpc-infura@9.1.0

[HowardBraham]

I did not intend to close this PR, it was an accident while trying to investigate the prep-deps issue. I now cannot open it again.