Skip to content

Conversation

@dcversus
Copy link

@dcversus dcversus commented Feb 28, 2024

Description

SuperLumio follows the same gas rules as Optimism. This closely follows the form of #20097.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Open the extension
  2. Add SuperLumio network
  3. Use faucet and/or make some transactions

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@dcversus dcversus requested a review from a team as a code owner February 28, 2024 17:49
@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added external-contributor INVALID-PR-TEMPLATE PR's body doesn't match template labels Feb 28, 2024
@dcversus
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@metamaskbot metamaskbot removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Feb 29, 2024
@dcversus
Copy link
Author

I don't understand why prep-deps fell down, but it seems I'm not the only one with a similar problem https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/70632/workflows/2d556239-621e-4312-9d4b-30e971f5e07f/jobs/2368800 and #23129 (review)

@HowardBraham HowardBraham changed the base branch from develop to fix-external-contribs March 11, 2024 19:26
@HowardBraham HowardBraham force-pushed the fix-external-contribs branch from 1739225 to 776217d Compare March 13, 2024 01:50
@dcversus dcversus requested review from a team, brad-decker and kumavis as code owners March 13, 2024 01:50
@HowardBraham HowardBraham force-pushed the fix-external-contribs branch from 73ec512 to 792400a Compare March 13, 2024 19:06
@HowardBraham HowardBraham deleted the branch MetaMask:fix-external-contribs March 13, 2024 21:47
@dcversus
Copy link
Author

dcversus commented Mar 14, 2024

Greetings @HowardBraham!
As far as I understand, there was no intention of closing the PR, was there? I have opened a new one #23486, I apologise if something is wrong).

@HowardBraham
Copy link
Contributor

@dcversus I was just trying to fix prep-deps, and closed it by mistake, sorry. Thanks for re-opening!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants