fix: misleading gas fee label in UI

[maczniak]

Description

The UI label for max base fee per gas is "Max base fee" (key maxBaseFee). I correct this label to "Max fee" (key maxFee). Thank Hee Jung Sonny Son for reporting!

Related issues

Manual testing steps

Screenshots/Recordings

Before

screenshot in English https://gist.github.com/assets/3060954/a1850425-f25a-46a3-960c-5ab36c390632
screenshot in Korean https://gist.github.com/assets/3060954/6737b0c5-778b-43d4-bd0c-393e4b664aad

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[maczniak]

I have read the CLA Document and I hereby sign the CLA

[HowardBraham]

I'm confused about why this PR fails the step prep-deps, but also, I think the screen is correct as-is. It's the maximum of how much you will pay for the "base fee."

[maczniak]

In the first screenshot,

• Max fee 0.00026301 ETH
• Max base fee 12.5244
• Priority Fee 0.0565
• Gas limit 21000

I did simple math.
fee = (base fee + priority fee) * gas amount
0.00026301 * 10^18 = (12.5244) * 10^9 * 21000 =/= (12.5244 + 0.0565) * 10^9 * 21000

Wait... Yes, technically, max base fee (per gas) is the same as max fee (per gas) because it is a upper limit. If it is intended, please ignore this pull request.

[HowardBraham]

Hmm, I think it IS wrong, but in a different way. I think the "Max fee" in ETH is not counting the "Priority fee." I'm going to post this internally and get opinions.

[segun]

Follow up on slack discussion around this issue https://consensys.slack.com/archives/C4V2HTG0Y/p1708710402351709

[brad-decker]

Erroneously approved. waiting for resolution of conversation internally.

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

[digiwand]

The update looks good to me. Base fee ≠ MaxFeePerGas and Max Fee Per Gas may be shortened to Max Fee.

If we wanted to also display the base fee, we could add this in a follow-up PR.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.77%. Comparing base (eb95d86) to head (dfd1ea8).
Report is 34 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #22434      +/-   ##
===========================================
- Coverage    65.77%   65.77%   -0.00%     
===========================================
  Files         1366     1366              
  Lines        54254    54254              
  Branches     14101    14101              
===========================================
- Hits         35685    35684       -1     
- Misses       18569    18570       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.