Skip to content

Conversation

@HowardBraham
Copy link
Contributor

@HowardBraham HowardBraham commented Sep 25, 2025

Description

Updates our own @metamask/auto-changelog package, from a weird npx @metamask/auto-changelog@4.1.0 to a proper yarn installed v5.1.0

  • Requires Prettier v3, and changes some Prettier line break rules
  • Turns on --autoCategorize
  • Uses the brand new options --useChangelogEntry and --useShortPrLink

@socket-security
Copy link

Caution

MetaMask internal reviewing guidelines:

  • Do not ignore-all
  • Each alert has instructions on how to review if you don't know what it means. If lost, ask your Security Liaison or the supply-chain group
  • Copy-paste ignore lines for specific packages or a group of one kind with a note on what research you did to deem it safe.
    @SocketSecurity ignore npm/PACKAGE@VERSION
Action Severity Alert  (click "▶" to expand/collapse)
Block Medium
prettier@3.6.2 has Network access.

Module: globalThis["fetch"]

Location: Package overview

From: package.jsonnpm/prettier@3.6.2

ℹ Read more on: This package | This alert | What is network access?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/prettier@3.6.2. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn Low
prettier@3.6.2 is a AI-detected potential code anomaly.

Notes: No definitive malware detected in this fragment. The main security concern is supply-chain risk from dynamically loading plugins from potentially untrusted sources. To mitigate, enforce strict plugin provenance, disable remote plugin loading, verify plugin integrity, and apply least-privilege execution for plugins.

Confidence: 1.00

Severity: 0.60

From: package.jsonnpm/prettier@3.6.2

ℹ Read more on: This package | This alert | What is an AI-detected potential code anomaly?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: An AI system found a low-risk anomaly in this package. It may still be fine to use, but you should check that it is safe before proceeding.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/prettier@3.6.2. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@HowardBraham HowardBraham marked this pull request as ready for review September 25, 2025 18:51
Copy link
Contributor

@XxdpavelxX XxdpavelxX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just want to confirm, is changing from "chore" -> "release" naming a desired change?

@HowardBraham HowardBraham merged commit 6c47e93 into main Sep 25, 2025
19 of 20 checks passed
@HowardBraham HowardBraham deleted the update-auto-changelog branch September 25, 2025 18:54
!Object.values(changelogChanges)
.flat()
.some((entry) => entry.includes(`[#${prNumber}]`))
.some((entry) => entry.prNumbers.includes(prNumber))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Changelog PR Number Type Mismatch

The updated changelog check entry.prNumbers.includes(prNumber) introduces two issues. prNumber comes in as a string from command line arguments, but entry.prNumbers likely contains numbers, causing includes() to always fail due to type mismatch. Also, if entry.prNumbers is missing or not an array, calling .includes() will result in a runtime TypeError.

Fix in Cursor Fix in Web

github-merge-queue bot pushed a commit to MetaMask/metamask-extension that referenced this pull request Sep 26, 2025
## **Description**

Updates `github-tools` to after MetaMask/github-tools#133 so we get
@metamask/auto-changelog v5.1.0

## **Changelog**
CHANGELOG entry: null

<!--## **Related issues**
## **Manual testing steps**
## **Screenshots/Recordings**
## **Pre-merge author checklist**
## **Pre-merge reviewer checklist**-->
runway-github bot added a commit to MetaMask/metamask-extension that referenced this pull request Oct 8, 2025
## **Description**

Updates `github-tools` to after MetaMask/github-tools#133 so we get
@metamask/auto-changelog v5.1.0

## **Changelog**
CHANGELOG entry: null

<!--## **Related issues**
## **Manual testing steps**
## **Screenshots/Recordings**
## **Pre-merge author checklist**
## **Pre-merge reviewer checklist**-->
runway-github bot added a commit to MetaMask/metamask-extension that referenced this pull request Oct 8, 2025
## **Description**

Updates `github-tools` to after MetaMask/github-tools#133 so we get
@metamask/auto-changelog v5.1.0

## **Changelog**
CHANGELOG entry: null

<!--## **Related issues**
## **Manual testing steps**
## **Screenshots/Recordings**
## **Pre-merge author checklist**
## **Pre-merge reviewer checklist**-->
runway-github bot added a commit to MetaMask/metamask-extension that referenced this pull request Oct 8, 2025
## **Description**

Updates `github-tools` to after MetaMask/github-tools#133 so we get
@metamask/auto-changelog v5.1.0

## **Changelog**
CHANGELOG entry: null

<!--## **Related issues**
## **Manual testing steps**
## **Screenshots/Recordings**
## **Pre-merge author checklist**
## **Pre-merge reviewer checklist**-->
runway-github bot pushed a commit to MetaMask/metamask-extension that referenced this pull request Oct 8, 2025
…ngelog (#36351)

## **Description**

Updates `github-tools` to after MetaMask/github-tools#133 so we get
@metamask/auto-changelog v5.1.0

## **Changelog**
CHANGELOG entry: null

<!--## **Related issues**
## **Manual testing steps**
## **Screenshots/Recordings**
## **Pre-merge author checklist**
## **Pre-merge reviewer checklist**-->
gauthierpetetin pushed a commit to MetaMask/metamask-extension that referenced this pull request Oct 8, 2025
## **Description**

Updates `github-tools` to after MetaMask/github-tools#133 so we get
@metamask/auto-changelog v5.1.0

## **Changelog**
CHANGELOG entry: null

<!--## **Related issues**
## **Manual testing steps**
## **Screenshots/Recordings**
## **Pre-merge author checklist**
## **Pre-merge reviewer checklist**-->
gauthierpetetin pushed a commit to MetaMask/metamask-extension that referenced this pull request Oct 8, 2025
…ngelog (#36698)

- ci: update github-tools for new auto-changelog (#36351)

## **Description**

Updates `github-tools` to after MetaMask/github-tools#133 so we get
@metamask/auto-changelog v5.1.0

## **Changelog**
CHANGELOG entry: null

<!--## **Related issues**
## **Manual testing steps**
## **Screenshots/Recordings**
## **Pre-merge author checklist**
## **Pre-merge reviewer checklist**-->
[17d008f](17d008f)

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Updates the reusable `MetaMask/github-tools` workflow and
`github-tools-version` SHA in `.github/workflows/create-release-pr.yml`.
> 
> - **CI/Workflows**:
> - Update reusable workflow reference in
`.github/workflows/create-release-pr.yml` to
`MetaMask/github-tools/.github/workflows/create-release-pr.yml@6c47e935...`.
> - Bump `github-tools-version` input to
`6c47e935b9de693c70db009fc2e4e1dd0df4e71e`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
aebfcfb. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: Howard Braham <howrad@gmail.com>
cryptodev-2s added a commit that referenced this pull request Nov 6, 2025
After updating to @metamask/auto-changelog v5.1.0 in PR #133, the parseChangelog
function requires the shouldExtractPrLinks option to be set to true in order to
populate the prNumbers array in changelog entries. Without this option, prNumbers
would be empty, causing a runtime error when checking if the current PR number
is included in the changelog entries.

This fix ensures that PR links are properly extracted and validated during the
changelog check process.
cryptodev-2s added a commit that referenced this pull request Nov 6, 2025
…#159)

After updating to @metamask/auto-changelog v5.1.0 in PR #133, the parseChangelog
function requires the shouldExtractPrLinks option to be set to true in order to
populate the prNumbers array in changelog entries. Without this option, prNumbers
would be empty, causing a runtime error when checking if the current PR number
is included in the changelog entries.

This fix ensures that PR links are properly extracted and validated during the
changelog check process.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants