-
-
Notifications
You must be signed in to change notification settings - Fork 4
ci: update auto-changelog to v5.1.0 #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution MetaMask internal reviewing guidelines:
|
XxdpavelxX
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just want to confirm, is changing from "chore" -> "release" naming a desired change?
| !Object.values(changelogChanges) | ||
| .flat() | ||
| .some((entry) => entry.includes(`[#${prNumber}]`)) | ||
| .some((entry) => entry.prNumbers.includes(prNumber)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Changelog PR Number Type Mismatch
The updated changelog check entry.prNumbers.includes(prNumber) introduces two issues. prNumber comes in as a string from command line arguments, but entry.prNumbers likely contains numbers, causing includes() to always fail due to type mismatch. Also, if entry.prNumbers is missing or not an array, calling .includes() will result in a runtime TypeError.
## **Description** Updates `github-tools` to after MetaMask/github-tools#133 so we get @metamask/auto-changelog v5.1.0 ## **Changelog** CHANGELOG entry: null <!--## **Related issues** ## **Manual testing steps** ## **Screenshots/Recordings** ## **Pre-merge author checklist** ## **Pre-merge reviewer checklist**-->
## **Description** Updates `github-tools` to after MetaMask/github-tools#133 so we get @metamask/auto-changelog v5.1.0 ## **Changelog** CHANGELOG entry: null <!--## **Related issues** ## **Manual testing steps** ## **Screenshots/Recordings** ## **Pre-merge author checklist** ## **Pre-merge reviewer checklist**-->
## **Description** Updates `github-tools` to after MetaMask/github-tools#133 so we get @metamask/auto-changelog v5.1.0 ## **Changelog** CHANGELOG entry: null <!--## **Related issues** ## **Manual testing steps** ## **Screenshots/Recordings** ## **Pre-merge author checklist** ## **Pre-merge reviewer checklist**-->
## **Description** Updates `github-tools` to after MetaMask/github-tools#133 so we get @metamask/auto-changelog v5.1.0 ## **Changelog** CHANGELOG entry: null <!--## **Related issues** ## **Manual testing steps** ## **Screenshots/Recordings** ## **Pre-merge author checklist** ## **Pre-merge reviewer checklist**-->
…ngelog (#36351) ## **Description** Updates `github-tools` to after MetaMask/github-tools#133 so we get @metamask/auto-changelog v5.1.0 ## **Changelog** CHANGELOG entry: null <!--## **Related issues** ## **Manual testing steps** ## **Screenshots/Recordings** ## **Pre-merge author checklist** ## **Pre-merge reviewer checklist**-->
## **Description** Updates `github-tools` to after MetaMask/github-tools#133 so we get @metamask/auto-changelog v5.1.0 ## **Changelog** CHANGELOG entry: null <!--## **Related issues** ## **Manual testing steps** ## **Screenshots/Recordings** ## **Pre-merge author checklist** ## **Pre-merge reviewer checklist**-->
…ngelog (#36698) - ci: update github-tools for new auto-changelog (#36351) ## **Description** Updates `github-tools` to after MetaMask/github-tools#133 so we get @metamask/auto-changelog v5.1.0 ## **Changelog** CHANGELOG entry: null <!--## **Related issues** ## **Manual testing steps** ## **Screenshots/Recordings** ## **Pre-merge author checklist** ## **Pre-merge reviewer checklist**--> [17d008f](17d008f) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Updates the reusable `MetaMask/github-tools` workflow and `github-tools-version` SHA in `.github/workflows/create-release-pr.yml`. > > - **CI/Workflows**: > - Update reusable workflow reference in `.github/workflows/create-release-pr.yml` to `MetaMask/github-tools/.github/workflows/create-release-pr.yml@6c47e935...`. > - Bump `github-tools-version` input to `6c47e935b9de693c70db009fc2e4e1dd0df4e71e`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit aebfcfb. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Howard Braham <howrad@gmail.com>
After updating to @metamask/auto-changelog v5.1.0 in PR #133, the parseChangelog function requires the shouldExtractPrLinks option to be set to true in order to populate the prNumbers array in changelog entries. Without this option, prNumbers would be empty, causing a runtime error when checking if the current PR number is included in the changelog entries. This fix ensures that PR links are properly extracted and validated during the changelog check process.
…#159) After updating to @metamask/auto-changelog v5.1.0 in PR #133, the parseChangelog function requires the shouldExtractPrLinks option to be set to true in order to populate the prNumbers array in changelog entries. Without this option, prNumbers would be empty, causing a runtime error when checking if the current PR number is included in the changelog entries. This fix ensures that PR links are properly extracted and validated during the changelog check process.
Description
Updates our own
@metamask/auto-changelogpackage, from a weirdnpx @metamask/auto-changelog@4.1.0to a proper yarn installed v5.1.0--autoCategorize--useChangelogEntryand--useShortPrLink