Skip to content

Conversation

@HowardBraham
Copy link
Contributor

@HowardBraham HowardBraham commented Sep 25, 2025

Description

Updates github-tools to after MetaMask/github-tools#133 so we get @metamask/auto-changelog v5.1.0

Changelog

CHANGELOG entry: null

@HowardBraham HowardBraham self-assigned this Sep 25, 2025
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@HowardBraham HowardBraham added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Sep 25, 2025
@metamaskbot metamaskbot added the team-extension-platform Extension Platform team label Sep 25, 2025
@HowardBraham HowardBraham marked this pull request as ready for review September 25, 2025 20:54
@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 2490b6b | Date: 9/25/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±69ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 737ms (±67ms) 🟢 | historical mean value: 736ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 78ms (±13ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 69ms 1.01s 1.34s 1.26s 1.34s
domContentLoaded 737ms 67ms 697ms 1.02s 933ms 1.02s
firstPaint 78ms 13ms 64ms 192ms 88ms 192ms
firstContentfulPaint 78ms 13ms 64ms 192ms 88ms 192ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [2490b6b]
UI Startup Metrics (1237 ± 56 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1237113714525612731320
load106395412134810971139
domContentLoaded105694612094810861133
domInteractive18145171737
firstPaint65090114343310791121
backgroundConnect2572442747261268
firstReactRender2717136152647
getState1253571429
initialActions60436717
loadScripts80669894247838879
setupStore1063041021
WebpackHomeuiStartup1132911142611312081308
load951747124110810111114
domContentLoaded946745123610810071111
domInteractive15124171437
firstPaint1496430854176257
backgroundConnect15104861529
firstReactRender35336143540
getState74213712
initialActions62204814
loadScripts943742123410810041108
setupStore86192813
FirefoxBrowserifyHomeuiStartup14171212176810314961619
load1234105914938712981390
domContentLoaded1233105914928712971390
domInteractive1093427746118219
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3421147193463
firstReactRender27236042830
getState63788610
initialActions3111249
loadScripts1208104014678512731362
setupStore12520721940
WebpackHomeuiStartup16381436215414217331895
load13821203164811914801589
domContentLoaded13811203164811914791589
domInteractive1063535256103276
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3321105103846
firstReactRender39335144146
getState10320426712
initialActions511331358
loadScripts13581177162311914521565
setupStore136152181129
Benchmark value 1237 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 257 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 269 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 47 exceeds gate value 45 for chrome browserify home p95 firstReactRender
Benchmark value 17 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 21 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1417 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 34 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 219 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 9 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 40 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1638 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1382 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1382 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 107 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 40 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 276 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 8 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 29 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 337ms | Sum of p95 exceeds: 450.8ms
Sum of all benchmark exceeds: 787.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 287 Bytes (0%)
  • common: 1.64 KiB (0.02%)

@HowardBraham HowardBraham added this pull request to the merge queue Sep 26, 2025
Merged via the queue into main with commit 17d008f Sep 26, 2025
288 of 293 checks passed
@HowardBraham HowardBraham deleted the update-github-tools branch September 26, 2025 06:21
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2025
@metamaskbot metamaskbot added the release-13.5.0 Issue or pull request that will be included in release 13.5.0 label Sep 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-13.5.0 Issue or pull request that will be included in release 13.5.0 size-XS team-extension-platform Extension Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants