temp+ci: update github-tools for new auto-changelog (#36351)

## **Description**

Updates `github-tools` to after MetaMask/github-tools#133 so we get
@metamask/auto-changelog v5.1.0

## **Changelog**
CHANGELOG entry: null

<!--## **Related issues**
## **Manual testing steps**
## **Screenshots/Recordings**
## **Pre-merge author checklist**
## **Pre-merge reviewer checklist**-->

Author: runway-github[bot]

.depcheckrc.yml

@@ -96,8 +96,6 @@ ignores:
   - '@metamask/bitcoin-wallet-snap'
   - '@metamask/solana-wallet-snap'
   - '@metamask/institutional-wallet-snap'
-  - '@metamask/gator-permissions-snap'
-  - '@metamask/permissions-kernel-snap'
 
 # files depcheck should not parse
 ignorePatterns:

.github/CODEOWNERS

@@ -65,16 +65,19 @@ tailwind.config.js                   @MetaMask/design-system-engineers
 **/pages/notification*/**                           @MetaMask/notifications
 **/utils/notification.util.ts                       @MetaMask/notifications
 
+# Identity team is responsible for authentication and backup and sync inside the Extension.
+# Slack handle: @identity_team | Slack channel: #metamask-identity
+**/identity/**                                          @MetaMask/identity
+
 # Accounts team is responsible for code related with snap management accounts
 # Slack handle: @accounts-team-devs | Slack channel: #metamask-accounts-team
 
 app/scripts/lib/snap-keyring                        @MetaMask/accounts-engineers
 
-# Multichain Accounts, Authentication, Backup and sync
-# Those features are owned by the multichain account tiger team
+# Multichain Accounts
+# This feature is owned by the multichain account tiger team
 # Slack handle: @multichain-accounts-devs | Slack channel: #metamask-bip44-team
 **/multichain-accounts/**                           @MetaMask/accounts-engineers
-**/identity/**                                      @MetaMask/accounts-engineers
 
 # Swaps-Bridge team to own code for the swaps folder
 ui/pages/swaps                                        @MetaMask/swaps-engineers
@@ -96,21 +99,20 @@ app/scripts/constants/snaps.ts       @MetaMask/core-platform
 # Co-owned by Confirmations and Snaps
 ui/components/app/metamask-template-renderer @MetaMask/confirmations @MetaMask/core-platform
 
-# Core Extension UX
-ui/components/app/whats-new-popup     @MetaMask/core-extension-ux
-ui/css                                @MetaMask/core-extension-ux
-ui/pages/home                         @MetaMask/core-extension-ux
-ui/pages/core                         @MetaMask/core-extension-ux
-ui/components/multichain/             @MetaMask/core-extension-ux
-
-# Co-owned by accounts and core-extension-ux
-ui/components/multichain/multi-srp/              @MetaMask/accounts-engineers @MetaMask/core-extension-ux
-ui/components/multichain/account-picker/         @MetaMask/accounts-engineers @MetaMask/core-extension-ux
-ui/components/multichain/account-details/        @MetaMask/accounts-engineers @MetaMask/core-extension-ux
-ui/components/multichain/account-overview/       @MetaMask/accounts-engineers @MetaMask/core-extension-ux
-ui/components/multichain/account-list-item/      @MetaMask/accounts-engineers @MetaMask/core-extension-ux
-ui/components/multichain/account-list-menu/      @MetaMask/accounts-engineers @MetaMask/core-extension-ux
-ui/components/multichain/account-list-item-menu/ @MetaMask/accounts-engineers @MetaMask/core-extension-ux
+# Wallet UX
+ui/components/app/whats-new-popup     @MetaMask/wallet-ux
+ui/css                                @MetaMask/wallet-ux
+ui/pages/home                         @MetaMask/wallet-ux
+ui/components/multichain/             @MetaMask/wallet-ux
+
+# Co-owned by accounts and wallet-ux
+ui/components/multichain/multi-srp/              @MetaMask/accounts-engineers @MetaMask/wallet-ux
+ui/components/multichain/account-picker/         @MetaMask/accounts-engineers @MetaMask/wallet-ux
+ui/components/multichain/account-details/        @MetaMask/accounts-engineers @MetaMask/wallet-ux
+ui/components/multichain/account-overview/       @MetaMask/accounts-engineers @MetaMask/wallet-ux
+ui/components/multichain/account-list-item/      @MetaMask/accounts-engineers @MetaMask/wallet-ux
+ui/components/multichain/account-list-menu/      @MetaMask/accounts-engineers @MetaMask/wallet-ux
+ui/components/multichain/account-list-item-menu/ @MetaMask/accounts-engineers @MetaMask/wallet-ux
 
 # Web3Auth / Onboarding
 ui/pages/onboarding-flow              @MetaMask/web3auth

.github/guidelines/LABELING_GUIDELINES.md

@@ -2,41 +2,38 @@
 
 To maintain a consistent and efficient development workflow, we have set specific label guidelines for all pull requests (PRs). Please ensure you adhere to the following instructions:
 
-## Mandatory team label (automated)
+### Mandatory team labels:
 
 - **Internal Developers**: Every PR raised by an internal developer must include a label prefixed with `team-` (e.g., `team-extension-ux`, `team-extension-platform`, etc.). This indicates the respective internal team responsible for the PR.
 
 - **External Contributors**: PRs submitted by contributors who are not part of the organization will be automatically labeled with `external-contributor`.
 
-## Mandatory checklog entry or label (manual addition)
+It's essential to ensure that PRs have the appropriate labels before they are considered for merging.
 
-The releases changelog generation is based on PR's changelog entries.
-The check can be bypassed when necessary, either by setting the changelog entry to "null" or by adding following label:
+### Mandatory release version labels:
 
-- **no-changelog**: PR's changes do not need to be included in the changelog.
-
-## Optional labels (manual addition)
-
-Any label can be manually added on demand depending on the PR's content. For instance, the label **QA passed** will indicate that a thorough manual testing has been performed and the PR is ready to be merged. In addition, following labels have some specific use cases.
+- **release-x.y.z**: This label is automatically added to a PR and its linked issues upon the PR's merge. The `x.y.z` in the label represents the version in which the changes from the PR will be included. This label is auto-generated by a [GitHub action](../workflows/add-release-label.yml), which determines the version by incrementing the minor version number from the most recent release. Manual intervention is only required in specific cases. For instance, if a merged PR is cherry-picked into a release branch, typically done to address Release Candidate (RC) bugs, the label would need to be manually updated to reflect the correct version.
+- **regression-prod-x.y.z**: This label is automatically added to a bug report issue at the time of its creation. The `x.y.z` in the label represents the version in which the bug first appeared. This label is auto-generated by a [GitHub action](../workflows/check-template-and-add-labels.yml), which determines the `x.y.z` value based on the version information provided in the bug report issue form. Manual intervention is only necessary under certain circumstances. For example, if a user submits a bug report and specifies the version they are currently using, but the bug was actually introduced in a prior version, the label would need to be manually updated to accurately reflect the version where the bug originated.
+- **regression-RC-x.y.z**: This label is manually added to a bug report issue by release engineers when a bug is found during release regerssion testing phase. The `x.y.z` in the label represents the release candidate (RC) version in which the bug's been discovered.
 
-### Bypass Quality Gates
+### Optional labels:
 
-Using any of these labels should be exceptional in case of CI friction and urgencies. Please use them reasonably and verify new changes and regressions manually.
+- **regression-main**: This label can manually be added to a bug report issue at the time of its creation if the bug is present on the development branch, i.e., `main`, but is not yet released in production.
+- **feature-branch-bug**: This label can manually be added to a bug report issue at the time of its creation if the bug is present on a feature branch, i.e., before merging to `main`.
+- **needs-qa**: If the PR includes a new features, complex testing steps, or large refactors, this label must be added to indicated PR requires a full manual QA prior being merged and added to a release.
 
-- **skip-e2e-quality-gate**: This label will disable the default test retries for E2E test files modified in the PR. Useful when making large refactors or when changes don't pose flakiness risk.
+### Labels prohibited when PR needs to be merged:
 
-### Block merge if any is present
+Any PR that includes one of the following labels can not be merged:
 
 - **needs-qa**: The PR requires a full manual QA prior to being merged and added to a release.
+- **QA'd but questions**: The PR has been checked by QA, but there are pending questions or clarifications needed on minor issues that were found.
+- **issues-found**: The PR has been checked by QA or other reviewers, and appeared to include issues that need to be addressed.
 - **need-ux-ds-review**: The PR requires a review from the User Experience or Design System teams.
 - **blocked**: There are unresolved dependencies or other issues blocking the progress of this PR.
 - **stale**: The PR has not had recent activity in the last 90 days. It will be closed in 7 days.
 - **DO-NOT-MERGE**: The PR should not be merged under any circumstances.
 
-## Release version label (automated)
-
-- **release-x.y.z**: This label is automatically added to a PR and its linked issues upon the PR's merge. The `x.y.z` in the label represents the version in which the changes from the PR will be included. This label is auto-generated by a [GitHub action](../workflows/add-release-label.yml), which determines the version by incrementing the minor version number from the most recent release. Manual intervention is only required in specific cases. For instance, if a merged PR is cherry-picked into a release branch, typically done to address Release Candidate (RC) bugs, the label would need to be manually updated to reflect the correct version.
-
 To maintain code quality and project integrity, it's crucial to respect these label guidelines. Please ensure you review and update labels appropriately throughout the PR lifecycle.
 
 Thank you for your cooperation!

.github/scripts/check-pr-has-required-labels.ts

@@ -42,6 +42,8 @@ async function main(): Promise<void> {
 
   const preventMergeLabels = [
     'needs-qa',
+    "QA'd but questions",
+    'issues-found',
     'need-ux-ds-review',
     'blocked',
     'stale',

.github/scripts/split-tests-by-timings.ts

@@ -10,7 +10,7 @@ import {
 // Quality Gate Retries
 const RETRIES_FOR_NEW_OR_CHANGED_TESTS = 4;
 
-function readTestResults(TEST_RESULTS_PATH: string): TestRun {
+function readTestResults(TEST_RESULTS_PATH: string): TestRun | undefined {
   const testSuiteName =
     process.env.TEST_SUITE_NAME || 'test-e2e-chrome-browserify';
 
@@ -19,12 +19,9 @@ function readTestResults(TEST_RESULTS_PATH: string): TestRun {
       readFileSync(TEST_RESULTS_PATH, 'utf8'),
     );
 
-    const testRun: TestRun = testRuns.find(
+    const testRun: TestRun | undefined = testRuns.find(
       (run) => run.name === testSuiteName,
-    ) || { // If the TestRun is not found, return a dummy object to do the naïve split
-      name: testSuiteName,
-      testFiles: [],
-    };
+    );
 
     return testRun;
   } catch (error) {
@@ -85,22 +82,31 @@ export function splitTestsByTimings(
     TEST_RESULTS_FILE = `test/test-results/test-runs-${process.env.SELENIUM_BROWSER}.json`,
   } = process.env;
 
-  const testRunLastTime = readTestResults(TEST_RESULTS_FILE);
-  let testRunNew: TestRun = { name: testRunLastTime.name, testFiles: [] };
+  try {
+    const testRunLastTime = readTestResults(TEST_RESULTS_FILE);
 
-  testList.forEach((path) => {
-    const testFileLastTime = testRunLastTime.testFiles.find(
-      (file) => file.path === path,
-    );
+    if (testRunLastTime) {
+      let testRunNew: TestRun = { name: testRunLastTime.name, testFiles: [] };
 
-    if (testFileLastTime) {
-      testRunNew.testFiles.push(testFileLastTime);
-    } else {
-      testRunNew.testFiles.push(getNewBlankTestFile(path));
+      testList.forEach((path) => {
+        const testFileLastTime = testRunLastTime.testFiles.find(
+          (file) => file.path === path,
+        );
+
+        if (testFileLastTime) {
+          testRunNew.testFiles.push(testFileLastTime);
+        } else {
+          testRunNew.testFiles.push(getNewBlankTestFile(path));
+        }
+      });
+
+      return splitTests(testRunNew, changedOrNewTests, totalChunks);
     }
-  });
+  } catch (error) {
+    console.trace(error);
+  }
 
-  return splitTests(testRunNew, changedOrNewTests, totalChunks);
+  return [];
 }
 
 /**

.github/workflows/release-pr-approval.yml

@@ -7,7 +7,7 @@ on:
       - release/*
 
 jobs:
-  check:
+  release-pr-approval:
     runs-on: ubuntu-latest
     steps:
       - name: Require Release Team approval

.gitignore

@@ -71,9 +71,6 @@ test-results/
 !.yarn/versions
 development/generate-attributions/.yarn/*
 
-# This entry would keep track of the yarn binaries tarball generated by corepack
-!.yarn/yarn-corepack.tgz
-
 # MetaMask
 .metamask/*
 

.storybook/locales.js

@@ -34,6 +34,7 @@ import * as mr from '../app/_locales/mr/messages.json';
 import * as ms from '../app/_locales/ms/messages.json';
 import * as nl from '../app/_locales/nl/messages.json';
 import * as no from '../app/_locales/no/messages.json';
+import * as ph from '../app/_locales/ph/messages.json';
 import * as pl from '../app/_locales/pl/messages.json';
 import * as pt from '../app/_locales/pt/messages.json';
 import * as pt_BR from '../app/_locales/pt_BR/messages.json';
@@ -48,68 +49,10 @@ import * as sw from '../app/_locales/sw/messages.json';
 import * as ta from '../app/_locales/ta/messages.json';
 import * as te from '../app/_locales/te/messages.json';
 import * as th from '../app/_locales/th/messages.json';
-import * as tl from '../app/_locales/tl/messages.json';
 import * as tr from '../app/_locales/tr/messages.json';
 import * as uk from '../app/_locales/uk/messages.json';
 import * as vi from '../app/_locales/vi/messages.json';
 import * as zh_CN from '../app/_locales/zh_CN/messages.json';
 import * as zh_TW from '../app/_locales/zh_TW/messages.json';
 
-export {
-  am,
-  ar,
-  bg,
-  bn,
-  ca,
-  cs,
-  da,
-  de,
-  el,
-  en,
-  es,
-  es_419,
-  et,
-  fa,
-  fi,
-  fil,
-  fr,
-  gu,
-  he,
-  hi,
-  hn,
-  hr,
-  ht,
-  hu,
-  id,
-  it,
-  ja,
-  kn,
-  ko,
-  lt,
-  lv,
-  ml,
-  mr,
-  ms,
-  nl,
-  no,
-  pl,
-  pt,
-  pt_BR,
-  pt_PT,
-  ro,
-  ru,
-  sk,
-  sl,
-  sr,
-  sv,
-  sw,
-  ta,
-  te,
-  th,
-  tl,
-  tr,
-  uk,
-  vi,
-  zh_CN,
-  zh_TW,
-};
+export { am, ar, bg, bn, ca, cs, da, de, el, en, es, es_419, et, fa, fi, fil, fr, gu, he, hi, hn, hr, ht, hu, id, it, ja, kn, ko, lt, lv, ml, mr, ms, nl, no, ph, pl, pt, pt_BR, pt_PT, ro, ru, sk, sl, sr, sv, sw, ta, te, th, tr, uk, vi, zh_CN, zh_TW };

.vscode/package.json-schema.json

@@ -25,14 +25,6 @@
             "postinstall": {
               "type": "string",
               "description": "Runs automatically after running `yarn` (`yarn install`) in order to prime the webpack dev build."
-            },
-            "yarn-binary:download": {
-              "type": "string",
-              "description": "Downloads and packages the yarn version specified in package.json packageManager field into .yarn/yarn-corepack.tgz for offline use."
-            },
-            "yarn-binary:hydrate": {
-              "type": "string",
-              "description": "Activates the yarn version from the committed .yarn/yarn-corepack.tgz tarball using corepack hydrate."
             }
           }
         },

.yarn/patches/@metamask-assets-controllers-npm-76.0.0-95e99a2835.patch renamed to .yarn/patches/@metamask-assets-controllers-npm-74.3.2-900afb3754.patch

@@ -1,5 +1,5 @@
 diff --git a/dist/assetsUtil.cjs b/dist/assetsUtil.cjs
-index b3db76c39d78362273ff081d8c8efe30040ffc28..cab60d3a8541ad0459112638f027c7e303b68b1e 100644
+index 2c759f2ecc76b0a6f467166a2e4d077dc951445e..a29468add0e2c43015be096f3aba3271879d735d 100644
 --- a/dist/assetsUtil.cjs
 +++ b/dist/assetsUtil.cjs
 @@ -3,6 +3,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
@@ -10,16 +10,12 @@ index b3db76c39d78362273ff081d8c8efe30040ffc28..cab60d3a8541ad0459112638f027c7e3
  exports.accountAddressToCaipReference = exports.getKeyByValue = exports.fetchTokenContractExchangeRates = exports.reduceInBatchesSerially = exports.divideIntoBatches = exports.ethersBigNumberToBN = exports.addUrlProtocolPrefix = exports.getFormattedIpfsUrl = exports.getIpfsCIDv1AndPath = exports.removeIpfsProtocolPrefix = exports.isTokenListSupportedForNetwork = exports.isTokenDetectionSupportedForNetwork = exports.SupportedStakedBalanceNetworks = exports.SupportedTokenDetectionNetworks = exports.formatIconUrlWithProxy = exports.formatAggregatorNames = exports.hasNewCollectionFields = exports.compareNftMetadata = exports.TOKEN_PRICES_BATCH_SIZE = void 0;
  const controller_utils_1 = require("@metamask/controller-utils");
  const utils_1 = require("@metamask/utils");
-@@ -240,7 +241,12 @@ async function getIpfsCIDv1AndPath(ipfsUrl) {
+@@ -237,7 +238,8 @@ async function getIpfsCIDv1AndPath(ipfsUrl) {
      const index = url.indexOf('/');
      const cid = index !== -1 ? url.substring(0, index) : url;
      const path = index !== -1 ? url.substring(index) : undefined;
 -    const { CID } = await import("multiformats");
-+    // Dynamic import is used here in `core` for CJS compatbility, because 'multiformats' is ESM-
-+    // only. However, dynamic import is not supported by LavaMoat.
-+    // See here for details: https://github.com/MetaMask/metamask-extension/pull/27629#discussion_r1791797810
-+    // TODO: Attempt deleting this patch after migrating to Webpack, which may support dynamic
-+    // import with LavaMoat.
++    // Use CJS require to allow Jest to parse without ESM transform
 +    const { CID } = _interopRequireWildcard(require("multiformats"));
      // We want to ensure that the CID is v1 (https://docs.ipfs.io/concepts/content-addressing/#identifier-formats)
      // because most cid v0s appear to be incompatible with IPFS subdomains