Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove change id from output #515

Conversation

sileht
Copy link
Member

@sileht sileht commented Oct 23, 2024

It's not really useful, user just want the PR url and sha1.

Depends-On: #514

It's not really useful, user just want the PR url and sha1.

Change-Id: I15c68bd3827b7668e7d932f419c313e7a33ba829
@sileht
Copy link
Member Author

sileht commented Oct 23, 2024

This pull request is part of a stack:

  1. chore: move more things in Changes/LocalChange object (#507)
  2. chore: move retrieval of change IDs and pull inside get_remote_changes() (#508)
  3. fix: all short sha are wrong (#509)
  4. refactor: pre compute the action to do for each change of the stack (#510)
  5. refactor: check API response globally (#511)
  6. chore: use a more reliable solution to get changes (#512)
  7. fix: logging in debug mode (#513)
  8. chore: add timing to HTTP request logs (#514)
  9. chore: remove change id from output (#515) 👈

Copy link
Contributor

mergify bot commented Oct 23, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

⛓️ Depends-On Requirements

Requirement based on the presence of Depends-On in the body of the pull request

Changelog requirements

  • any of:
    • -title ~= ^feat
    • label = need changelog
    • label = skip changelog

🔎 Reviews

  • #review-requested = 0
  • #changes-requested-reviews-by = 0
  • #review-threads-unresolved = 0

@mergify mergify bot requested a review from a team October 23, 2024 18:56
@sileht sileht closed this Oct 23, 2024
@sileht sileht deleted the devs/sileht/merged-handling/I15c68bd3827b7668e7d932f419c313e7a33ba829 branch October 23, 2024 18:57
@sileht sileht deleted the branch devs/sileht/merged-handling/I270faa533639cf73af9b488d7d1796c71a4d62bb October 23, 2024 18:57
@sileht sileht closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant