Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: logging in debug mode #513

Closed
wants to merge 4 commits into from
Closed

fix: logging in debug mode #513

wants to merge 4 commits into from

Conversation

sileht
Copy link
Member

@sileht sileht commented Oct 23, 2024

Depends-On: #512

sileht added 2 commits October 23, 2024 20:31
@sileht
refactor: pre compute the action to do for each change of the stack
f33eaf3 
This will help to do/display the same thing in the dry-run and the
effective run.

Change-Id: Id57cf9a1af904636b84fe49940a7202ee70b7b84
@sileht
refactor: check API response globally
f115504 
Change-Id: I79aa6f8ebb983924a004f9942d2abfab1d8c27a9
This was referenced Oct 23, 2024
Closed
Merged
Merged
Merged
Merged
@sileht
Copy link
Member Author

sileht commented Oct 23, 2024 •
edited
Loading

This pull request is part of a stack:

  1. chore: move more things in Changes/LocalChange object (#507)
  2. chore: move retrieval of change IDs and pull inside get_remote_changes() (#508)
  3. fix: all short sha are wrong (#509)
  4. refactor: pre compute the action to do for each change of the stack (#510)
  5. refactor: check API response globally (#511)
  6. chore: use a more reliable solution to get changes (#512)
  7. fix: logging in debug mode (#513) 👈

This was referenced Oct 23, 2024
Merged
Merged
@mergify mergify bot requested a review from a team October 23, 2024 18:50
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 23, 2024 •
edited
Loading

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

⛓️ Depends-On Requirements

Requirement based on the presence of Depends-On in the body of the pull request

Changelog requirements

  • any of:
    • -title ~= ^feat
    • label = need changelog
    • label = skip changelog

🔎 Reviews

  • #review-requested = 0
  • #changes-requested-reviews-by = 0
  • #review-threads-unresolved = 0

sileht added 2 commits October 23, 2024 20:52
@sileht
chore: use a more reliable solution to get changes
56d1bd6 
Using Git database API does not work for merged PR as the reference of
the deleted branch vanish faster.

This leverages the search API instead.

Change-Id: I4d66da7449c347a5197fa8bc2ee02a5bd517fec1
@sileht
fix: logging in debug mode
011b01b 
Change-Id: Ifec7a6d0d92067cbee8ca9136474b6925db84bd5
@sileht sileht force-pushed the devs/sileht/merged-handling/I4d66da7449c347a5197fa8bc2ee02a5bd517fec1 branch from e155352 to 56d1bd6 Compare October 23, 2024 18:52
@sileht sileht force-pushed the devs/sileht/merged-handling/Ifec7a6d0d92067cbee8ca9136474b6925db84bd5 branch from d630e45 to 011b01b Compare October 23, 2024 18:52
@sileht sileht mentioned this pull request Oct 23, 2024
Closed
@sileht sileht force-pushed the devs/sileht/merged-handling/I4d66da7449c347a5197fa8bc2ee02a5bd517fec1 branch from 56d1bd6 to c534402 Compare October 23, 2024 18:59
@sileht sileht closed this Oct 23, 2024
@sileht sileht deleted the devs/sileht/merged-handling/Ifec7a6d0d92067cbee8ca9136474b6925db84bd5 branch October 23, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sileht