Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move more things in Changes/LocalChange object #507

Merged
merged 1 commit into from
Oct 24, 2024
Merged

chore: move more things in Changes/LocalChange object #507

merged 1 commit into from
Oct 24, 2024

Conversation

sileht
Copy link
Member

@sileht sileht commented Oct 23, 2024 •
edited
Loading

No description provided.

This was referenced Oct 23, 2024
Merged
Merged
@sileht
Copy link
Member Author

sileht commented Oct 23, 2024 •
edited
Loading

This pull request is part of a stack:

  1. chore: move more things in Changes/LocalChange object (#507) 👈
  2. chore: move retrieval of change IDs and pull inside get_remote_changes() (#508)
  3. fix: all short sha are wrong (#509)
  4. refactor: pre compute the action to do for each change of the stack (#510)
  5. refactor: check API response globally (#511)
  6. chore: use a more reliable solution to get changes (#512)

@sileht sileht mentioned this pull request Oct 23, 2024
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 23, 2024 •
edited
Loading

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

Changelog requirements

  • any of:
    • -title ~= ^feat
    • label = need changelog
    • label = skip changelog

Enforce conventional commit

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🔎 Reviews

  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

@mergify mergify bot requested a review from a team October 23, 2024 12:13
@sileht sileht mentioned this pull request Oct 23, 2024
Merged
@sileht sileht force-pushed the devs/sileht/merged-handling/I5eb9a48dd4789fe58e10f5e9140cbf2f44d78f1c branch from 0b3fba3 to 285c6ad Compare October 23, 2024 13:47
@sileht sileht force-pushed the devs/sileht/merged-handling/Ie0d2f713a5c3f1094a282b69ec6abee2f44e688e branch from 01e1166 to aeb8c73 Compare October 23, 2024 13:47
Base automatically changed from devs/sileht/merged-handling/I5eb9a48dd4789fe58e10f5e9140cbf2f44d78f1c to main October 23, 2024 13:55
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 23, 2024

@sileht this pull request is now in conflict 😩

@mergify mergify bot added the conflict label Oct 23, 2024
@sileht sileht changed the title chore: move more things in Changes/Local Change object chore: move more things in Changes/LocalChange object Oct 23, 2024
@sileht
chore: move more things in Changes/Local Change object
3045ed8 
Change-Id: Ie0d2f713a5c3f1094a282b69ec6abee2f44e688e
@sileht sileht force-pushed the devs/sileht/merged-handling/Ie0d2f713a5c3f1094a282b69ec6abee2f44e688e branch from aeb8c73 to 3045ed8 Compare October 23, 2024 18:49
This was referenced Oct 23, 2024
Merged
Merged
Closed
Closed
@mergify mergify bot removed the conflict label Oct 23, 2024
@sileht sileht mentioned this pull request Oct 23, 2024
Closed
@mergify mergify bot merged commit 0c0efa4 into main Oct 24, 2024
5 checks passed
@mergify mergify bot added the queued label Oct 24, 2024
@mergify mergify bot deleted the devs/sileht/merged-handling/Ie0d2f713a5c3f1094a282b69ec6abee2f44e688e branch October 24, 2024 06:17
@mergify mergify bot removed the queued label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jd jd jd approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sileht @jd