Improving LLVM tests #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farazs-github
requested changes
May 30, 2023
Member
farazs-github
left a comment
farazs-github
left a comment
There was a problem hiding this comment.
Comments added. At least one change needs further inputs from @cme
llvm/test/tools/UpdateTestChecks/update_llc_test_checks/mips_generated_funcs.test
Outdated
Show resolved
Hide resolved
- Fix instructions conflicts between NanoMips and other Mips targets that caused tests from the MC/Mips group to fail - Fix several tests - Fix debug location of SP adjustment instruction that caused DebugInfo/Mips/delay-slot.ll test to fail - Add 'nanomips' feature to llvm-lit config script so that tests can be marked as UNSUPPORTED for NanoMips target
nikolaperic
force-pushed
the
tests-improvement
branch
from
f74fe37 to
b2e79de
Compare
farazs-github
requested changes
Jun 16, 2023
added 2 commits
June 16, 2023 14:12
- Fix expected output for jumptable.ll and mips_generated_funcs.ll tests
- No longer need to mark a test ExtDebugInfo.cpp that needs object emitter as UNSUPPORTED - Delete line left behind by a merge conflict in sanitize-coverage-old-pm.c test
Collaborator
Author
|
Added one more commit which fixes last two of failing clang tests. Test |
This was referenced Jul 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fix the remaining 13 failing LLVM tests when running
ninja check-llvm: